Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23681

Check, in the unit tests, that fitPtcAndNonLinearity returns what it is supposed to return.

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      In test_ptc.py of cp_pipe there are multiple calls to fitPtcAndNonLinearity. Check the return value of that function with any one (or all) of those.

        Attachments

          Issue Links

            Activity

            Hide
            swinbank John Swinbank added a comment -

            I took a look at the changes on GitHub, and made a couple of comments.

            However, at the moment, I think these test only check the case when tableArray is provided. Per discussion on DM-23873, I think you need to merge that ticket, rebase this against it, and make sure you're testing all possible combinations of arguments before we can complete this review.

            Show
            swinbank John Swinbank added a comment - I took a look at the changes on GitHub, and made a couple of comments. However, at the moment, I think these test only check the case when tableArray is provided. Per discussion on DM-23873 , I think you need to merge that ticket, rebase this against it, and make sure you're testing all possible combinations of arguments before we can complete this review.
            Hide
            plazas Andrés Alejandro Plazas Malagón added a comment -

            Thank you for your comments. I have addressed them and pushed a new version of the code.

            Show
            plazas Andrés Alejandro Plazas Malagón added a comment - Thank you for your comments. I have addressed them and pushed a new version of the code.
            Hide
            swinbank John Swinbank added a comment -

            Thank you! Changes look good to me, assuming that:

            • Jenkins is happy;
            • You fix the outstanding Flake 8 error.

            Show
            swinbank John Swinbank added a comment - Thank you! Changes look good to me, assuming that: Jenkins is happy; You fix the outstanding Flake 8 error.

              People

              • Assignee:
                plazas Andrés Alejandro Plazas Malagón
                Reporter:
                plazas Andrés Alejandro Plazas Malagón
                Reviewers:
                John Swinbank
                Watchers:
                Andrés Alejandro Plazas Malagón, John Swinbank, Merlin Fisher-Levine
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel