Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23699

Update fgcmcal default config format to remove possibility of index errors

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: fgcmcal
    • Labels:
      None
    • Story Points:
      2
    • Epic Link:
    • Sprint:
      DRP S20-3 (Feb)
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      The configuration format for FgcmFitCycleTask has some elements that must be specified in band order. While this was fine (such as it was) with 5 bands (g,r,i,z,y), with the addition of several narrow-bands this has become more obviously unwieldy. It would be easy to change these configs to use dictionary mappings instead of ordered lists which would remove ambiguity and make mis-configurations much less likely.

        Attachments

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          lauren Lauren MacArthur added a comment -

          Some comments on the PRs, but looks good to me (although, admittedly, I’m relying somewhat on your personal testing...). A green Jenkins & you’re good to go.

          Show
          lauren Lauren MacArthur added a comment - Some comments on the PRs, but looks good to me (although, admittedly, I’m relying somewhat on your personal testing...). A green Jenkins & you’re good to go.
          Hide
          Permalink
          erykoff Eli Rykoff added a comment -

          A combo-jenkins. First run passed centos, mysterious transient problem on macos. https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31339/pipeline Second run passed macos: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31344/pipeline

          Show
          erykoff Eli Rykoff added a comment - A combo-jenkins. First run passed centos, mysterious transient problem on macos. https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31339/pipeline Second run passed macos: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31344/pipeline

            People

            Assignee:
            erykoff Eli Rykoff
            Reporter:
            erykoff Eli Rykoff
            Reviewers:
            Lauren MacArthur
            Watchers:
            Eli Rykoff, Lauren MacArthur
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.