Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23848

Put the Rotator into Standby State after the clearError Command

    XMLWordPrintable

    Details

      Description

      Put the rotator PXI into the standby state after clearing the error. This task will need to update the Simulink model for the state machine transition. This task also needs to write the related test in Simulink to testify this change. After this, I will need to generate the C/C++ code and put back to ts_rotator_controller and test the new built. I need to think I can test this in C/C++ level in additional to the Simulink level or not.

        Attachments

          Issue Links

            Activity

            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            Updated the state machine in rotator Simulink model to transit to the Standby state from the Fault state after clearing the error. The transition of Fault state is by the state transition command. The result is in the figure:

            Show
            ttsai Te-Wei Tsai added a comment - - edited Updated the state machine in rotator Simulink model to transit to the Standby state from the Fault state after clearing the error. The transition of Fault state is by the state transition command. The result is in the figure:
            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            Entered the Fault state by errorCheck and left to Standby state by clearError:

            Show
            ttsai Te-Wei Tsai added a comment - - edited Entered the Fault state by errorCheck and left to Standby state by clearError:
            Hide
            ttsai Te-Wei Tsai added a comment -

            Updated the documents of ts_mt_hexRot_simulink repository.

            Show
            ttsai Te-Wei Tsai added a comment - Updated the documents of ts_mt_hexRot_simulink repository.
            Hide
            ttsai Te-Wei Tsai added a comment -

            Added the cpSimCntlr.sh and copied the files of simulink code to ts_rotator_controller. The Jenkins build passed.

            Show
            ttsai Te-Wei Tsai added a comment - Added the cpSimCntlr.sh and copied the files of simulink code to ts_rotator_controller. The Jenkins build passed.
            Hide
            ttsai Te-Wei Tsai added a comment -

            Put the system into the Standby state instead of Offline-PublishOnly state after clearing the error.

            The PRs are:

            1. https://github.com/lsst-ts/ts_mt_hexRot_simulink/pull/2

            2. https://github.com/lsst-ts/ts_rotator_controller/pull/4

            Please note the main effort in this ticket is the Simulink model, not the C code. The only part I think is relevant to code is here:
            https://github.com/lsst-ts/ts_rotator_controller/blob/tickets/DM-23848/src/smlnkModel/rotator_smlnk_Controller.c#L982-L986

            The Jenkins test is here:
            https://tssw-ci.lsst.org/job/LSST_Telescope-and-Site/job/ts_rotator_controller/job/tickets%252FDM-23848/

            Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Put the system into the Standby state instead of Offline-PublishOnly state after clearing the error. The PRs are: 1.  https://github.com/lsst-ts/ts_mt_hexRot_simulink/pull/2 2.  https://github.com/lsst-ts/ts_rotator_controller/pull/4 Please note the main effort in this ticket is the Simulink model, not the C code. The only part I think is relevant to code is here: https://github.com/lsst-ts/ts_rotator_controller/blob/tickets/DM-23848/src/smlnkModel/rotator_smlnk_Controller.c#L982-L986 The Jenkins test is here: https://tssw-ci.lsst.org/job/LSST_Telescope-and-Site/job/ts_rotator_controller/job/tickets%252FDM-23848/ Thanks!
            Hide
            rowen Russell Owen added a comment -

            This looks very nice. A big improvement.

            I hope you plan to make the same change for the hexapod.

            Show
            rowen Russell Owen added a comment - This looks very nice. A big improvement. I hope you plan to make the same change for the hexapod.

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              Russell Owen
              Watchers:
              Russell Owen, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Start date:
                End date:

                  Jenkins Builds

                  No builds found.