Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_main_telescope
-
Labels:
-
Story Points:3
-
Sprint:TSSW Sprint - Mar 30 - Apr 13
-
Team:Telescope and Site
-
Urgent?:No
Description
Put the rotator PXI into the standby state after clearing the error. This task will need to update the Simulink model for the state machine transition. This task also needs to write the related test in Simulink to testify this change. After this, I will need to generate the C/C++ code and put back to ts_rotator_controller and test the new built. I need to think I can test this in C/C++ level in additional to the Simulink level or not.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Summary | Put the Rotator into Standby State after the clearError | Put the Rotator into Standby State after the clearError Command |
| Description | Put the rotator PXI into the standby state after clear the error. | Put the rotator PXI into the standby state after clearing the error. |
| End date | 10/Apr/20 | |
| Sprint | TSSW Sprint - Mar 30 - Apr 13 [ 1009 ] | |
| Start date | 06/Apr/20 | |
| Story Points | 3 | |
| Description | Put the rotator PXI into the standby state after clearing the error. | Put the rotator PXI into the standby state after clearing the error. This task will need to update the Simulink model for the state machine transition. This task also needs to write the related test in Simulink to testify this change. After this, I will need to generate the C/C++ code and put back to ts_rotator_controller and test the new built. I need to think I can test this in C/C++ level in additional to the Simulink level or not. |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Attachment | states.png [ 43422 ] |
| Attachment | faultStateByClearError.png [ 43440 ] |
| Attachment | faultStateByClearError.png [ 43440 ] |
| Attachment | faultStateByCheckError.png [ 43441 ] |
Entered the Fault state by errorCheck and left to Standby state by clearError:
Updated the documents of ts_mt_hexRot_simulink repository.
Added the cpSimCntlr.sh and copied the files of simulink code to ts_rotator_controller. The Jenkins build passed.
Put the system into the Standby state instead of Offline-PublishOnly state after clearing the error.
The PRs are:
1. https://github.com/lsst-ts/ts_mt_hexRot_simulink/pull/2
2. https://github.com/lsst-ts/ts_rotator_controller/pull/4
Please note the main effort in this ticket is the Simulink model, not the C code. The only part I think is relevant to code is here:
https://github.com/lsst-ts/ts_rotator_controller/blob/tickets/DM-23848/src/smlnkModel/rotator_smlnk_Controller.c#L982-L986
The Jenkins test is here:
https://tssw-ci.lsst.org/job/LSST_Telescope-and-Site/job/ts_rotator_controller/job/tickets%252FDM-23848/
Thanks!
| Reviewers | Russell Owen [ rowen ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
This looks very nice. A big improvement.
I hope you plan to make the same change for the hexapod.
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
Updated the state machine in rotator Simulink model to transit to the Standby state from the Fault state after clearing the error. The transition of Fault state is by the state transition command. The result is in the figure: