Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_main_telescope
-
Labels:
-
Story Points:4
-
Epic Link:
-
Sprint:TSSW Sprint - Nov 08 - Nov 22, TSSW Sprint - Nov 22 - Dec 06
-
Team:Telescope and Site
-
Urgent?:No
Description
Acknowledge the SAL command from Rotator PXI. This will let the CSC know the status of SAL command.
Note. It looks like I may need to use sync pattern to identify the command comes from the DDS or GUI. Only the CSC needs the command acknowledgement. In addition, in the future, the GUI specific code will be deprecated. There should be no difference between the GUI and CSC code at that time. In this case, I may need to update the GUI code to use another sync pattern value instead.
Note. I do need to change the GUI for sync pattern.
Attachments
Issue Links
- is blocked by
-
DM-32472 Refactor the commanding.c in Rotator Low-Level Controller
- Done
- is triggering
-
DM-32693 Update MT hexapod and rotator CSCs to read command ack messages
- Done
-
DM-32727 Update the Rotator EUI to Read the Command Status
- Done
-
DM-32730 Reply the Command Status of State Transition of Rotator Controller
- Done
-
DM-33068 Test the New Version of Rotator Code on Summit
- Done
- relates to
-
DM-31232 Acknowledge the SAL Command from Hexapod PXI
- Done
The current command c struct does have a "counter" field (the 2nd field) that is a unique identifier for each command. This is ideal for identifying the command when reporting command success or failure.
The minimum needed information is "command rejected" or "command done".
Other items that would be very helpful:
It is probably possible to add this information to the Telemetry struct, but please consider making a new struct (if that will not mess up the EUI) because the information really is not very "telemetry-like" and it only needs to be output when a command is accepted, rejected or done.
I will be delighted to make any necessary changes to the CSC.