Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-23998

Update ts_MTMount based on new information from Tekniker

    XMLWordPrintable

    Details

    • Story Points:
      3
    • Epic Link:
    • Sprint:
      TSSW Sprint - Mar 16 - Mar 30
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      Update the ts_MTMount code based on my conversation with Alberto 2020-03-23. Changes include:

      • Enforce only one command at a time.
      • The source field of errors and warnings is a string of the form f"{subsystem_id}. {text}", rather than a simple integer.
      • The CSC should not command the azimuth cable wrap; let the azimuth axis take care of it. Remove the azimuth cable wrap from the simulator.
      • Use the suggested startup sequence.
      • Add the suggested shutdown sequence.
      • Corrected the source-ish field for the error and warning replies. I had assumed it was an integer, but it turns out to be a string (that starts with an integer; it's ugly).

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-24045 Add unit tests for mock devices and the mock controller to MTMount

          • Done

          Improvement - An improvement or enhancement to an existing feature or task. DM-23186 Format my T&S packages with black as time permits

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Pull request: https://github.com/lsst-ts/ts_MTMount/pull/4

            Show
            rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_MTMount/pull/4
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Changes include (where "commands" refers to low-level commands that are sent to the low-level controller):

            • Added many new commands (mostly those I needed)
            • Removed the Azimuth Cable Wrap commands because the azimuth axis controls the azimuth cable wrap (at least as long as I don't try to interfere by sending commands to it)
            • Overhauled the code for enabling and disabling the command, based on recommendations from Tekniker (see https://docs.google.com/document/d/1e3Qam1VmmmckHlFpU5WPBHPaWGfrPsqt8zmGsiAhlnk for details).
            • Overhauled the code for opening and closing the mirror covers. I'm not sure the command sequence is correct yet (I have a query in to Tekniker about it), but it's my best guess for now.

            Note: I plan to add unit tests for the mock devices and mock controller in DM-24045. I wish I had been able to fit that into this ticket, but I ran out of time.

            Show
            rowen Russell Owen added a comment - - edited Changes include (where "commands" refers to low-level commands that are sent to the low-level controller): Added many new commands (mostly those I needed) Removed the Azimuth Cable Wrap commands because the azimuth axis controls the azimuth cable wrap (at least as long as I don't try to interfere by sending commands to it) Overhauled the code for enabling and disabling the command, based on recommendations from Tekniker (see https://docs.google.com/document/d/1e3Qam1VmmmckHlFpU5WPBHPaWGfrPsqt8zmGsiAhlnk for details). Overhauled the code for opening and closing the mirror covers. I'm not sure the command sequence is correct yet (I have a query in to Tekniker about it), but it's my best guess for now. Note: I plan to add unit tests for the mock devices and mock controller in DM-24045 . I wish I had been able to fit that into this ticket, but I ran out of time.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Reviewed on gihub. Thank you for catching the error.

            Show
            rowen Russell Owen added a comment - Reviewed on gihub. Thank you for catching the error.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Error corrected, questions answered, merged to develop and new documentation published here: https://ts-mtmount.lsst.io/builds/1/index.html

            Show
            rowen Russell Owen added a comment - Error corrected, questions answered, merged to develop and new documentation published here: https://ts-mtmount.lsst.io/builds/1/index.html

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Wouter van Reeven
              Watchers:
              Andrew Heyer [X] (Inactive), Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.