Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_modelfit
-
Labels:
-
Story Points:6
-
Epic Link:
-
Sprint:Measurement-S14-4
-
Team:Data Release Production
Description
Create meas_base Plugins for single-frame and forced measurement that uses the model-fitting primitives in meas_multifit to implement SDSS-style CModel magnitudes, in which we fit an exp and dev model separately and then fit the linear combination with ellipse parameters held fixed.
An old-style plugin has already been implemented on the HSC fork, and should be used as a guide; this issue involves adapting that implementation to meas_base and potentially cleaning it up a bit. Note that the HSC implementation cannot be transferred directly to the LSST side because the meas_algorithms APIs are slightly different on the two forks.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link | DM-15 [ 11263 ] |
| Sprint | Sprint 1 [ 39 ] |
| Rank | Ranked higher |
| Epic Link | DM-15 [ 11263 ] |
| Labels | Measurement |
| Rank | Ranked lower |
| Sprint | Sprint 1 [ 39 ] |
| Story Points | 20 | 8 |
| Sprint | Measurement-S14-4 [ 83 ] |
| Rank | Ranked higher |
| Rank | Ranked higher |
| Story Points | 8 | 6 |
| Assignee | Yusra AlSayyad [ yusra ] | Jim Bosch [ jbosch ] |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Rank | Ranked higher |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Review completed on GitHub. Most comments were just requests for clarification.
Biggest outcome was noticing an incorrect factor (2 instead of pi) in SoftenedLinearPrior normalization, which spurred an improvement in the unit test coverage for that class, uncovering a larger bug in prior evaluation. Neither of these problems would have affected the code as it is configured by default, but would have affected mode unusual configurations of the prior.
| Status | In Review [ 10004 ] | Review Complete [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Review Complete [ 10101 ] | Done [ 10002 ] |
| Component/s | meas_modelfit [ 11411 ] | |
| Component/s | meas_multifit [ 10739 ] |
| Team | Princeton [ 10301 ] |
Sending this to Bob Armstrong for review. He doesn't have a JIRA account yet, but he does have a GitHub account, and we'll do the review there anyway, and I'll paste a summary back here when we're done.