Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-242

switch from '.' to '_' in afw::table fields

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:

      Description

      We've been mapping '.' to '' in afw::table I/O, which unnecessarily complicates lots of things. We'd like to switch to using '' in the field names themselves, which requires ending this mapping in I/O, but we need to be backwards compatible. So we'll add a version to the FITS headers, and continue the mapping if the version is not present or is less than some value.

      Until we do this, the new field names being used in meas_base won't round-trip.

        Attachments

          Issue Links

          is blocked by

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-384 Add Versioning to SourceTable in lsst::afw::table

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            To be precise, on this issue I'll disable the "." to "_" translation for version>0 tables, while leaving it in place for version==0 tables.

            Show
            jbosch Jim Bosch added a comment - To be precise, on this issue I'll disable the "." to "_" translation for version>0 tables, while leaving it in place for version==0 tables.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Ready for review on tickets/DM-242; most of the new code is in tests:

            afw:tickets/DM-242 % git diff --stat master...tickets/DM-242
            		 
             src/table/io/FitsReader.cc |    9 ++++--
            		 
             src/table/io/FitsWriter.cc |   19 +++++++++----
            		 
             tests/testSimpleTable.py   |   66 ++++++++++++++++++++++++++++++++++++++++++++
            		 
             3 files changed, 86 insertions(+), 8 deletions(-)

            Show
            jbosch Jim Bosch added a comment - Ready for review on tickets/ DM-242 ; most of the new code is in tests: afw:tickets/DM-242 % git diff --stat master...tickets/DM-242 src/table/io/FitsReader.cc | 9 ++++-- src/table/io/FitsWriter.cc | 19 +++++++++---- tests/testSimpleTable.py | 66 ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 86 insertions(+), 8 deletions(-)
            Hide
            Permalink
            pgee Perry Gee added a comment -

            Looks good. Pretty much line-for-line what I did this weekend, which boosts my confidence.

            I also added changes to the SLOT persistence macros, which I will check in with the slot changes

            Show
            pgee Perry Gee added a comment - Looks good. Pretty much line-for-line what I did this weekend, which boosts my confidence. I also added changes to the SLOT persistence macros, which I will check in with the slot changes

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Perry Gee
              Watchers:
              Jim Bosch, Perry Gee
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.