Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2421

Improve support for Python modules in Scons

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      it seems we have two tools to manage python modules:

      • site_scons/pytarget.py and
      • site_scons/site_tools/pymod.py (grep for InstallPythonModule) used by admin tools. We could unify this, isn't it?

        Attachments

          Issue Links

            Activity

            Hide
            salnikov Andy Salnikov added a comment -

            After recent SConscript re-organization in DM-3447 site_scons/pytarget.py does not exist anymore. site_scons/site_tools/pymod.py but I do not think it's being used by anything. We should remove latter but we also want to improve Python module installation to take care of *.pyc files. site_scons/site_tools/pymod.py does something for that but it's not complete. So I propose to update pymod.py once DM-3447 is merged.

            Show
            salnikov Andy Salnikov added a comment - After recent SConscript re-organization in DM-3447 site_scons/pytarget.py does not exist anymore. site_scons/site_tools/pymod.py but I do not think it's being used by anything. We should remove latter but we also want to improve Python module installation to take care of *.pyc files. site_scons/site_tools/pymod.py does something for that but it's not complete. So I propose to update pymod.py once DM-3447 is merged.
            Hide
            salnikov Andy Salnikov added a comment -

            Fritz expressed mild interest in this so I assign review to him. Anyone else (Fabrice?) is welcome to look at it too.

            It has been tested sufficiently well, unit tests and integration all work OK, and it does not touch core stuff, only the build process, so review mostly concerns style and spell check

            Show
            salnikov Andy Salnikov added a comment - Fritz expressed mild interest in this so I assign review to him. Anyone else (Fabrice?) is welcome to look at it too. It has been tested sufficiently well, unit tests and integration all work OK, and it does not touch core stuff, only the build process, so review mostly concerns style and spell check
            Hide
            fritzm Fritz Mueller added a comment -

            Looks good to me, thanks! One minor comment typo in PR.

            Show
            fritzm Fritz Mueller added a comment - Looks good to me, thanks! One minor comment typo in PR.
            Hide
            salnikov Andy Salnikov added a comment -

            Thanks for review! Merged and pushed to master.

            Show
            salnikov Andy Salnikov added a comment - Thanks for review! Merged and pushed to master.

              People

              • Assignee:
                salnikov Andy Salnikov
                Reporter:
                jammes Fabrice Jammes
                Reviewers:
                Fritz Mueller
                Watchers:
                Andy Salnikov, Fabrice Jammes, Fritz Mueller, Jacek Becla
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel