Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2423

Weighting in photometric calibration is incorrect

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_photocal
    • Labels:
      None

      Description

      Dominique points out that the zero point calibration uses errors not inverse errors to calculate the zero point. git annotate reveals:

      24c9149f python/lsst/meas/photocal/PhotoCal.py (Robert Lupton the Good 2010-12-13 05:03:12 +0000 353) return np.average(dmag, weights=dmagErr), np.std(dmag, ddof=1), len(dmag)

      Please fix this. At the same time, we should add a config parameter to soften the errors.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Simon is super busy. Russell Owen, could you take on this review? It's a pretty small one.

            Show
            jbosch Jim Bosch added a comment - Simon is super busy. Russell Owen , could you take on this review? It's a pretty small one.
            Hide
            rowen Russell Owen added a comment -

            photoCal.py

            The changes look helpful.

            One small request: please change the final return to specify each value on its own line, as per the original code. I feel that makes it easier for a user to see exactly what named values are in the returned struct.

            testPhotocal.py

            The changes look helpful.

            Show
            rowen Russell Owen added a comment - photoCal.py The changes look helpful. One small request: please change the final return to specify each value on its own line, as per the original code. I feel that makes it easier for a user to see exactly what named values are in the returned struct. testPhotocal.py The changes look helpful.
            Hide
            jbosch Jim Bosch added a comment -

            One small request: please change the final return to specify each value on its own line, as per the original code. I feel that makes it easier for a user to see exactly what named values are in the returned struct.

            I find that a bit unnecessarily verbose, but I also don't care much. Will do.

            Show
            jbosch Jim Bosch added a comment - One small request: please change the final return to specify each value on its own line, as per the original code. I feel that makes it easier for a user to see exactly what named values are in the returned struct. I find that a bit unnecessarily verbose, but I also don't care much. Will do.
            Hide
            jbosch Jim Bosch added a comment -

            Merged to master.

            Show
            jbosch Jim Bosch added a comment - Merged to master.
            Hide
            rhl Robert Lupton added a comment -

            Yes.

            Show
            rhl Robert Lupton added a comment - Yes.

              People

              • Assignee:
                jbosch Jim Bosch
                Reporter:
                rhl Robert Lupton
                Reviewers:
                Russell Owen
                Watchers:
                Dominique Boutigny, Jim Bosch, rmandelb, Robert Lupton, Russell Owen, Simon Krughoff
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel