Details
-
Type:
Bug
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_photocal
-
Labels:None
-
Story Points:1
-
Epic Link:
-
Sprint:Science Pipelines DM-S15-5, Science Pipelines DM-S15-6
-
Team:Data Release Production
Description
Dominique points out that the zero point calibration uses errors not inverse errors to calculate the zero point. git annotate reveals:
24c9149f python/lsst/meas/photocal/PhotoCal.py (Robert Lupton the Good 2010-12-13 05:03:12 +0000 353) return np.average(dmag, weights=dmagErr), np.std(dmag, ddof=1), len(dmag)
Please fix this. At the same time, we should add a config parameter to soften the errors.
Attachments
Issue Links
- is contained by
-
DM-2308 Improve hacks in PhotoCalTask for dealing with reference flux uncertainties
- To Do
Activity
photoCal.py
The changes look helpful.
One small request: please change the final return to specify each value on its own line, as per the original code. I feel that makes it easier for a user to see exactly what named values are in the returned struct.
testPhotocal.py
The changes look helpful.
One small request: please change the final return to specify each value on its own line, as per the original code. I feel that makes it easier for a user to see exactly what named values are in the returned struct.
I find that a bit unnecessarily verbose, but I also don't care much. Will do.
Yes.
Simon is super busy. Russell Owen, could you take on this review? It's a pretty small one.