Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2423

Weighting in photometric calibration is incorrect

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_photocal
    • Labels:
      None

      Description

      Dominique points out that the zero point calibration uses errors not inverse errors to calculate the zero point. git annotate reveals:

      24c9149f python/lsst/meas/photocal/PhotoCal.py (Robert Lupton the Good 2010-12-13 05:03:12 +0000 353) return np.average(dmag, weights=dmagErr), np.std(dmag, ddof=1), len(dmag)

      Please fix this. At the same time, we should add a config parameter to soften the errors.

        Attachments

          Issue Links

            Activity

            rhl Robert Lupton created issue -
            swinbank John Swinbank made changes -
            Field Original Value New Value
            Team Data Release Production [ 10301 ]
            swinbank John Swinbank made changes -
            Issue Type Story [ 10001 ] Bug [ 1 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            swinbank John Swinbank made changes -
            Epic Link DM-1912 [ 15945 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-S15-5 [ 162 ]
            Assignee Robert Lupton [ rhl ] Jim Bosch [ jbosch ]
            jbosch Jim Bosch made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            jbosch Jim Bosch made changes -
            Story Points 1
            jbosch Jim Bosch made changes -
            Link This issue is contained by DM-2308 [ DM-2308 ]
            jbosch Jim Bosch made changes -
            Reviewers Simon Krughoff [ krughoff ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            jbosch Jim Bosch made changes -
            Status In Review [ 10004 ] In Progress [ 3 ]
            jbosch Jim Bosch made changes -
            Reviewers Simon Krughoff [ krughoff ] Russell Owen [ rowen ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-S15-5 [ 162 ] Science Pipelines DM-S15-5, Science Pipelines DM-S15-6 [ 162, 165 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            rowen Russell Owen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            jbosch Jim Bosch made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            rhl Robert Lupton made changes -
            Attachment signature.asc [ 27052 ]

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Russell Owen
              Watchers:
              Dominique Boutigny, Jim Bosch, Rachel Mandelbaum, Robert Lupton, Russell Owen, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.