Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw
-
Labels:None
-
Story Points:6
-
Epic Link:
-
Sprint:DRP F16-4, DRP F16-5, DRP F16-6
-
Team:Data Release Production
Description
Implement the core of the SpanSet class, as prototyped in RFC-37. This includes the following:
- All STL container methods and typedefs, and their Pythonic counterparts.
- All constructors and assignment operators, except for SpanSetBuilder. This includes the ability to detect and fix overlapping Spans.
- All simple accessors.
- isContiguous()
- The shift and clip methods.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Rank | Ranked higher |
| Rank | Ranked lower |
| Sprint | Science Pipelines DM-S15-2 [ 151 ] |
| Rank | Ranked lower |
| Sprint | Science Pipelines DM-S15-2 [ 151 ] | Science Pipelines DM-S15-3 [ 155 ] |
| Sprint | Science Pipelines DM-S15-3 [ 155 ] | Science Pipelines DM-S15-4 [ 159 ] |
| Sprint | Science Pipelines DM-S15-4 [ 159 ] |
| Assignee | John Swinbank [ swinbank ] |
| Summary | Implement SpanRegion core functionality | Implement SpanSet core functionality |
| Description |
Implement the core of the SpanRegion class, as prototyped in - The private implementation object and copy-on-write utilities (see Schema for an example of copy-on-write, but note that SpanRegion's implementation object can be private, while Schema's is not). - All STL container methods and typedefs, and their Pythonic counterparts. - All constructors and assignment operators, except for SpanRegionBuilder. This includes the ability to detect and fix overlapping Spans. - All simple accessors. - {{isContiguous()}} - The shift and clip methods. |
Implement the core of the SpanSet class, as prototyped in - All STL container methods and typedefs, and their Pythonic counterparts. - All constructors and assignment operators, except for SpanSetBuilder. This includes the ability to detect and fix overlapping Spans. - All simple accessors. - {{isContiguous()}} - The shift and clip methods. |
| Assignee | Nate Lust [ nlust ] |
| Sprint | DRP F16-4 [ 246 ] |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Sprint | DRP F16-4 [ 246 ] | DRP F16-4, DRP F16-5 [ 246, 252 ] |
| Rank | Ranked higher |
| Reviewers | Bob Armstrong [ rearmstr ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
| Watchers | Bob Armstrong, Jim Bosch, Nate Lust [ Bob Armstrong, Jim Bosch, Nate Lust ] | Bob Armstrong, Jim Bosch, Nate Lust, Pim Schellart [ Bob Armstrong, Jim Bosch, Nate Lust, Pim Schellart ] |
| Sprint | DRP F16-4, DRP F16-5 [ 246, 252 ] | DRP F16-4, DRP F16-5, DRP F16-6 [ 246, 252, 287 ] |
| Rank | Ranked higher |
Bob, I have made updates to this code. Would you like to look back over it?
| Resolution | Done [ 10000 ] | |
| Status | In Review [ 10004 ] | Done [ 10002 ] |
There is no single ticket that is best to review this work as it is spread over many tickets, so this will serve well enough. Thank you for agreeing to do this review. The work is all on the tickets/
DM-7170branch on afw. For your part of the review, please review SpanSets.h, SpanSets.cc, and the unit test. Within SpanSets.h you are not responsible for reviewing the applyFunctor(Impl) functions, just the normal class method. There are a few class methods which make use of that functionality, and you can decide for yourself if you want to look into those or not. If there are any questions, please send me a message here or on Slack.