Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2425

Implement SpanSet core functionality

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      6
    • Sprint:
      DRP F16-4, DRP F16-5, DRP F16-6
    • Team:
      Data Release Production

      Description

      Implement the core of the SpanSet class, as prototyped in RFC-37. This includes the following:

      • All STL container methods and typedefs, and their Pythonic counterparts.
      • All constructors and assignment operators, except for SpanSetBuilder. This includes the ability to detect and fix overlapping Spans.
      • All simple accessors.
      • isContiguous()
      • The shift and clip methods.

        Attachments

          Issue Links

            Activity

            No builds found.
            jbosch Jim Bosch created issue -
            jbosch Jim Bosch made changes -
            Field Original Value New Value
            Rank Ranked higher
            jbosch Jim Bosch made changes -
            Epic Link DM-1904 [ 15919 ]
            jbosch Jim Bosch made changes -
            Rank Ranked lower
            jbosch Jim Bosch made changes -
            Link This issue is blocked by DM-2424 [ DM-2424 ]
            jbosch Jim Bosch made changes -
            Link This issue blocks DM-2427 [ DM-2427 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-S15-2 [ 151 ]
            swinbank John Swinbank made changes -
            Rank Ranked lower
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-S15-2 [ 151 ] Science Pipelines DM-S15-3 [ 155 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-S15-3 [ 155 ] Science Pipelines DM-S15-4 [ 159 ]
            swinbank John Swinbank made changes -
            Sprint Science Pipelines DM-S15-4 [ 159 ]
            swinbank John Swinbank made changes -
            Epic Link DM-1904 [ 15919 ] DM-3559 [ 19648 ]
            swinbank John Swinbank made changes -
            Epic Link DM-3559 [ 19648 ] DM-1904 [ 15919 ]
            swinbank John Swinbank made changes -
            Epic Link DM-1904 [ 15919 ] DM-3559 [ 19648 ]
            swinbank John Swinbank made changes -
            Assignee John Swinbank [ swinbank ]
            nlust Nate Lust made changes -
            Summary Implement SpanRegion core functionality Implement SpanSet core functionality
            nlust Nate Lust made changes -
            Description Implement the core of the SpanRegion class, as prototyped in RFC-37. This includes the following:
             - The private implementation object and copy-on-write utilities (see Schema for an example of copy-on-write, but note that SpanRegion's implementation object can be private, while Schema's is not).
             - All STL container methods and typedefs, and their Pythonic counterparts.
             - All constructors and assignment operators, except for SpanRegionBuilder. This includes the ability to detect and fix overlapping Spans.
             - All simple accessors.
             - {{isContiguous()}}
             - The shift and clip methods.
            Implement the core of the SpanSet class, as prototyped in RFC-37. This includes the following:
             - All STL container methods and typedefs, and their Pythonic counterparts.
             - All constructors and assignment operators, except for SpanSetBuilder. This includes the ability to detect and fix overlapping Spans.
             - All simple accessors.
             - {{isContiguous()}}
             - The shift and clip methods.
            nlust Nate Lust made changes -
            Assignee Nate Lust [ nlust ]
            swinbank John Swinbank made changes -
            Sprint DRP F16-4 [ 246 ]
            nlust Nate Lust made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            swinbank John Swinbank made changes -
            Sprint DRP F16-4 [ 246 ] DRP F16-4, DRP F16-5 [ 246, 252 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            nlust Nate Lust made changes -
            Link This issue blocks DM-2426 [ DM-2426 ]
            nlust Nate Lust made changes -
            Link This issue blocks DM-7173 [ DM-7173 ]
            nlust Nate Lust made changes -
            Link This issue blocks DM-7174 [ DM-7174 ]
            Hide
            nlust Nate Lust added a comment -

            There is no single ticket that is best to review this work as it is spread over many tickets, so this will serve well enough. Thank you for agreeing to do this review. The work is all on the tickets/DM-7170 branch on afw. For your part of the review, please review SpanSets.h, SpanSets.cc, and the unit test. Within SpanSets.h you are not responsible for reviewing the applyFunctor(Impl) functions, just the normal class method. There are a few class methods which make use of that functionality, and you can decide for yourself if you want to look into those or not. If there are any questions, please send me a message here or on Slack.

            Show
            nlust Nate Lust added a comment - There is no single ticket that is best to review this work as it is spread over many tickets, so this will serve well enough. Thank you for agreeing to do this review. The work is all on the tickets/ DM-7170 branch on afw. For your part of the review, please review SpanSets.h, SpanSets.cc, and the unit test. Within SpanSets.h you are not responsible for reviewing the applyFunctor(Impl) functions, just the normal class method. There are a few class methods which make use of that functionality, and you can decide for yourself if you want to look into those or not. If there are any questions, please send me a message here or on Slack.
            nlust Nate Lust made changes -
            Reviewers Bob Armstrong [ rearmstr ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            nlust Nate Lust made changes -
            Watchers Bob Armstrong, Jim Bosch, Nate Lust [ Bob Armstrong, Jim Bosch, Nate Lust ] Bob Armstrong, Jim Bosch, Nate Lust, Pim Schellart [ Bob Armstrong, Jim Bosch, Nate Lust, Pim Schellart ]
            swinbank John Swinbank made changes -
            Sprint DRP F16-4, DRP F16-5 [ 246, 252 ] DRP F16-4, DRP F16-5, DRP F16-6 [ 246, 252, 287 ]
            swinbank John Swinbank made changes -
            Rank Ranked higher
            Hide
            nlust Nate Lust added a comment -

            Bob, I have made updates to this code. Would you like to look back over it?

            Show
            nlust Nate Lust added a comment - Bob, I have made updates to this code. Would you like to look back over it?
            Hide
            nlust Nate Lust added a comment -

            merged to master

            Show
            nlust Nate Lust added a comment - merged to master
            nlust Nate Lust made changes -
            Resolution Done [ 10000 ]
            Status In Review [ 10004 ] Done [ 10002 ]

              People

              Assignee:
              nlust Nate Lust
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Bob Armstrong
              Watchers:
              Bob Armstrong, Jim Bosch, Nate Lust, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.