Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: afw
-
Labels:None
-
Story Points:3
-
Epic Link:
-
Sprint:DRP F16-6
-
Team:Data Release Production
Description
Implement methods that apply arbitrary functors to pixels within a SpanSet, as described on RFC-37.
The only tricky part of this implementation will be the "traits" classes that allow different target objects to interpreted differently. I'd be happy to consult on this; I have a rough idea in my head, but it needs to be fleshed out.
Attachments
Issue Links
- is blocked by
-
- Done
Activity
In fact, it already is policy — it just isn't widely followed. I'll post something on clo to remind people.
Krzysztof Findeisen I think I have addressed most of your concerns, though some points I changed to something in between your comments and what I had. When You get a chance, will you take a look at the updated code? There is a commit for code updates and one for unit test updates. These will of course be squashed down after review.
Looks much better, though I still have some concerns about const-correctness and unit test coverage. Feel free to merge after you've gone through the comments on GitHub.
Krzysztof Findeisen
added a comment - Looks much better, though I still have some concerns about const-correctness and unit test coverage. Feel free to merge after you've gone through the comments on GitHub.
Krzysztof Findeisen John Swinbank I guess that this is due to the new Github review workflow. Perhaps we should make it policy that the person that creates the ticket also always creates the PR?