Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2427

Implement SpanSet applyFunctor methods

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • afw
    • None
    • 3
    • DRP F16-6
    • Data Release Production

    Description

      Implement methods that apply arbitrary functors to pixels within a SpanSet, as described on RFC-37.

      The only tricky part of this implementation will be the "traits" classes that allow different target objects to interpreted differently. I'd be happy to consult on this; I have a rough idea in my head, but it needs to be fleshed out.

      Attachments

        Issue Links

          Activity

            krzys swinbank I guess that this is due to the new Github review workflow. Perhaps we should make it policy that the person that creates the ticket also always creates the PR?

            pschella Pim Schellart [X] (Inactive) added a comment - krzys swinbank I guess that this is due to the new Github review workflow. Perhaps we should make it policy that the person that creates the ticket also always creates the PR?

            In fact, it already is policy — it just isn't widely followed. I'll post something on clo to remind people.

            swinbank John Swinbank added a comment - In fact, it already is policy — it just isn't widely followed. I'll post something on clo to remind people.
            nlust Nate Lust added a comment -

            krzys I think I have addressed most of your concerns, though some points I changed to something in between your comments and what I had. When You get a chance, will you take a look at the updated code? There is a commit for code updates and one for unit test updates. These will of course be squashed down after review.

            nlust Nate Lust added a comment - krzys I think I have addressed most of your concerns, though some points I changed to something in between your comments and what I had. When You get a chance, will you take a look at the updated code? There is a commit for code updates and one for unit test updates. These will of course be squashed down after review.

            Looks much better, though I still have some concerns about const-correctness and unit test coverage. Feel free to merge after you've gone through the comments on GitHub.

            krzys Krzysztof Findeisen added a comment - Looks much better, though I still have some concerns about const-correctness and unit test coverage. Feel free to merge after you've gone through the comments on GitHub.
            nlust Nate Lust added a comment -

            merged to master

            nlust Nate Lust added a comment - merged to master

            People

              nlust Nate Lust
              jbosch Jim Bosch
              Krzysztof Findeisen
              Jim Bosch, John Swinbank, Krzysztof Findeisen, Nate Lust, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.