Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2427

Implement SpanSet applyFunctor methods

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None

      Description

      Implement methods that apply arbitrary functors to pixels within a SpanSet, as described on RFC-37.

      The only tricky part of this implementation will be the "traits" classes that allow different target objects to interpreted differently. I'd be happy to consult on this; I have a rough idea in my head, but it needs to be fleshed out.

        Attachments

          Issue Links

            Activity

            Hide
            nlust Nate Lust added a comment -

            merged to master

            Show
            nlust Nate Lust added a comment - merged to master
            Hide
            krzys Krzysztof Findeisen added a comment -

            Looks much better, though I still have some concerns about const-correctness and unit test coverage. Feel free to merge after you've gone through the comments on GitHub.

            Show
            krzys Krzysztof Findeisen added a comment - Looks much better, though I still have some concerns about const-correctness and unit test coverage. Feel free to merge after you've gone through the comments on GitHub.
            Hide
            nlust Nate Lust added a comment -

            Krzysztof Findeisen I think I have addressed most of your concerns, though some points I changed to something in between your comments and what I had. When You get a chance, will you take a look at the updated code? There is a commit for code updates and one for unit test updates. These will of course be squashed down after review.

            Show
            nlust Nate Lust added a comment - Krzysztof Findeisen I think I have addressed most of your concerns, though some points I changed to something in between your comments and what I had. When You get a chance, will you take a look at the updated code? There is a commit for code updates and one for unit test updates. These will of course be squashed down after review.
            Hide
            swinbank John Swinbank added a comment -

            In fact, it already is policy — it just isn't widely followed. I'll post something on clo to remind people.

            Show
            swinbank John Swinbank added a comment - In fact, it already is policy — it just isn't widely followed. I'll post something on clo to remind people.
            Hide
            pschella Pim Schellart [X] (Inactive) added a comment -

            Krzysztof Findeisen John Swinbank I guess that this is due to the new Github review workflow. Perhaps we should make it policy that the person that creates the ticket also always creates the PR?

            Show
            pschella Pim Schellart [X] (Inactive) added a comment - Krzysztof Findeisen John Swinbank I guess that this is due to the new Github review workflow. Perhaps we should make it policy that the person that creates the ticket also always creates the PR?

              People

              Assignee:
              nlust Nate Lust
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Jim Bosch, John Swinbank, Krzysztof Findeisen, Nate Lust, Pim Schellart [X] (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.