Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24285

fitsExposureFormatter fails to read "Exposure" entries correctly

    Details

      Description

      Copying from slack so I don't get confused in the future:

      [...]
        File "/software/lsstsw/stack_20200220/stack/miniconda3-4.7.12-984c9f7/Linux64/daf_butler/19.0.0-41-g64a679d4/python/lsst/daf/butler/formatters/fitsExposureFormatter.py", line 138, in readFull
          return fileDescriptor.storageClass.pytype(fileDescriptor.location.path, **parameters)
      File "/software/lsstsw/stack_20200220/stack/miniconda3-4.7.12-984c9f7/Linux64/utils/19.0.0-7-g686a884+4/python/lsst/utils/wrappers.py", line 313, in __call__
          raise TypeError("No registered subclass for {}.".format(d))
      TypeError: No registered subclass for {'dtype': None}.
      [...]
        File "/software/lsstsw/stack_20200220/stack/miniconda3-4.7.12-984c9f7/Linux64/daf_butler/19.0.0-41-g64a679d4/python/lsst/daf/butler/_butler.py", line 693, in getDirect
          return self.datastore.get(ref, parameters=parameters)
        File "/software/lsstsw/stack_20200220/stack/miniconda3-4.7.12-984c9f7/Linux64/daf_butler/19.0.0-41-g64a679d4/python/lsst/daf/butler/datastores/posixDatastore.py", line 151, in get
          raise ValueError(f"Failure from formatter '{formatter.name()}' for Dataset {ref.id}") from e
      ValueError: Failure from formatter 'lsst.daf.butler.formatters.fitsExposureFormatter.FitsExposureFormatter' for Dataset 945

      Oh, wait, that's just invoking storageClass.pytype(...) (which will never work with just Exposure sans suffix) instead of using ExposureFitsReader.
      15:30
      This is a bug in the formatter, I think.

        Attachments

          Issue Links

            Activity

            Hide
            jbosch Jim Bosch added a comment -

            Comments on the PR.

            Show
            jbosch Jim Bosch added a comment - Comments on the PR.

              People

              • Assignee:
                czw Christopher Waters
                Reporter:
                czw Christopher Waters
                Reviewers:
                Jim Bosch
                Watchers:
                Christopher Waters, Jim Bosch, Tim Jenness
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: