Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24331

Fix ImageDifferenceTask and related v21 deprecation warnings

    XMLWordPrintable

Details

    • Story
    • Status: Done
    • Resolution: Done
    • None
    • None
    • None
    • 2
    • AP F20-5 (October), AP F20-6 (November)
    • Alert Production
    • No

    Description

      There are further occurrences of getImageF(void) and a getCentroidKey() that was spotted now.

      python/lsst/ip/diffim/diffimTools.py:309
        /ssd/gkovacs/devel/active/DM-21868_ip_diffim_decorr_afterburner/python/lsst/ip/diffim/diffimTools.py:309: FutureWarning: Call to deprecated method __init__. (Overloads that take a ``style`` parameter are deprecated; the style must be passed to `Background.getImageF` instead. To be removed after 20.0.0.)
          bctrl = afwMath.BackgroundControl(algorithm)
       
      python/lsst/ip/diffim/diffimTools.py:317
      python/lsst/ip/diffim/diffimTools.py:317
      python/lsst/ip/diffim/diffimTools.py:317
      python/lsst/ip/diffim/diffimTools.py:317
        /ssd/gkovacs/devel/active/DM-21868_ip_diffim_decorr_afterburner/python/lsst/ip/diffim/diffimTools.py:317: FutureWarning: Call to deprecated method getImageF(). (Zero-argument overload is deprecated; use one that takes an ``interpStyle`` instead. To be removed after 20.0.0.)
          image -= backobj.getImageF()
       
      python/lsst/ip/diffim/diffimTools.py:318
      python/lsst/ip/diffim/diffimTools.py:318
      python/lsst/ip/diffim/diffimTools.py:318
      python/lsst/ip/diffim/diffimTools.py:318
        /ssd/gkovacs/devel/active/DM-21868_ip_diffim_decorr_afterburner/python/lsst/ip/diffim/diffimTools.py:318: FutureWarning: Call to deprecated method getImageF(). (Zero-argument overload is deprecated; use one that takes an ``interpStyle`` instead. To be removed after 20.0.0.)
          backgrounds.append(backobj.getImageF())
       
      tests/test_kernelCandidateAndSolution.py:211
        /ssd/gkovacs/devel/active/DM-21868_ip_diffim_decorr_afterburner/tests/test_kernelCandidateAndSolution.py:211: FutureWarning: Call to deprecated method getCentroidKey. (Use `getCentroidSlot().getMeasKey()` instead. To be removed after 20.0.0.)
          source.set(self.table.getCentroidKey().getX(), 276)
       
      tests/test_kernelCandidateAndSolution.py:212
        /ssd/gkovacs/devel/active/DM-21868_ip_diffim_decorr_afterburner/tests/test_kernelCandidateAndSolution.py:212: FutureWarning: Call to deprecated method getCentroidKey. (Use `getCentroidSlot().getMeasKey()` instead. To be removed after 20.0.0.)
          source.set(self.table.getCentroidKey().getY(), 717)
      
      

      Attachments

        Issue Links

          Activity

            swinbank John Swinbank added a comment - - edited

            Note these are to be removed after v20.0.0. Since this isn't an API change we can do it any time before the release of v21.

            swinbank John Swinbank added a comment - - edited Note these are to be removed after v20.0.0. Since this isn't an API change we can do it any time before the release of v21.

            DM-24565 removed the deprecation of getImageF() in the meantime. The found occurrences below are left intact for now. This was discussed in slack here.

            meas_algorithms/tests/test_measure.py
            pipe_tasks/python/lsst/pipe/tasks/repair.py
            meas_algorithms/tests/test_cr.py
            ip_diffim/python/lsst/ip/diffim/diffimTools.py
            

             

            gkovacs Gabor Kovacs [X] (Inactive) added a comment - - edited DM-24565 removed the deprecation of getImageF() in the meantime. The found occurrences below are left intact for now. This was discussed in slack here . meas_algorithms/tests/test_measure.py pipe_tasks/python/lsst/pipe/tasks/repair.py meas_algorithms/tests/test_cr.py ip_diffim/python/lsst/ip/diffim/diffimTools.py  
            gkovacs Gabor Kovacs [X] (Inactive) added a comment - https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32968/pipeline

            According to krzys, this ticket may be fully contained by DM-22814. Now waiting for DM-22814 to be merged then this ticket may be completed or invalidated.

            gkovacs Gabor Kovacs [X] (Inactive) added a comment - According to krzys , this ticket may be fully contained by DM-22814 . Now waiting for DM-22814 to be merged then this ticket may be completed or invalidated.
            Parejkoj John Parejko added a comment -

            Marking this Invalid. On the `tickets/DM-22814` branch, ip_diffim builds without any afw-related deprecation warnings (just some for boost timer), so it looks like DM-22814 takes care of all of these (as it should).

            Parejkoj John Parejko added a comment - Marking this Invalid. On the `tickets/ DM-22814 ` branch, ip_diffim builds without any afw-related deprecation warnings (just some for boost timer), so it looks like DM-22814 takes care of all of these (as it should).

            The pipe_tasks occurrence seems still valid in imageDifference.py, though it may be in stale code, checking...

            gkovacs Gabor Kovacs [X] (Inactive) added a comment - - edited The pipe_tasks occurrence seems still valid in imageDifference.py , though it may be in stale code, checking...

            Thanks for catching this. Must be code that doesn't get executed by a test. I thought I did a search here, but clearly not (there were a lot of table-related deprecations).

            Please add a comment to the PR you closed stating why it was closed, just for the record.

            Parejkoj John Parejko added a comment - Thanks for catching this. Must be code that doesn't get executed by a test. I thought I did a search here, but clearly not (there were a lot of table-related deprecations). Please add a comment to the PR you closed stating why it was closed, just for the record.

            People

              gkovacs Gabor Kovacs [X] (Inactive)
              gkovacs Gabor Kovacs [X] (Inactive)
              John Parejko
              Gabor Kovacs [X] (Inactive), John Parejko, John Swinbank
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.