Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: obs_base
-
Story Points:1
-
Team:Architecture
-
Urgent?:No
Description
In DM-24285 we made reading components from exposures very efficient but inadvertently broke reading of components from raw files because the API was changed. Nothing in lsst_distrib or lsst_ci noticed and it wasn't until ci_hsc_gen2 that the breakage was discovered.
In that test we showed that reading raw.wcs does not give you the same thing as reading the raw and then calling getWcs. This is because the previous implementation did a full read and component extraction but now components are all handled by ExposureFitsReader.
Attachments
Issue Links
- is triggered by
-
DM-24285 fitsExposureFormatter fails to read "Exposure" entries correctly
- Done
Activity
As I understand it, this is conforming the API in FitsRawFormatterBase with the new one in FitsExposureFormatter from DM-24285.
The change and test look reasonable to accomplish this.
And for the record, the raw formatter has always ignored parameters so there is no change there (we may want to fix that but for now this ticket is not the place).
Kian-Tat Lim I added a test that broke obs_lsst (because it was erroneously returning a single amplifier) and then just combined the two distinct component reading routines into one.