Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24337

Fix raw formatter gen3 breakage

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      In DM-24285 we made reading components from exposures very efficient but inadvertently broke reading of components from raw files because the API was changed. Nothing in lsst_distrib or lsst_ci noticed and it wasn't until ci_hsc_gen2 that the breakage was discovered.

      In that test we showed that reading raw.wcs does not give you the same thing as reading the raw and then calling getWcs. This is because the previous implementation did a full read and component extraction but now components are all handled by ExposureFitsReader.

        Attachments

          Issue Links

            Activity

            tjenness Tim Jenness created issue -
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Link This issue is triggered by DM-24285 [ DM-24285 ]
            tjenness Tim Jenness made changes -
            Labels gen2-deprecation-blocker gen3-middleware
            tjenness Tim Jenness made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            tjenness Tim Jenness made changes -
            Component/s obs_decam [ 12851 ]
            Component/s obs_lsst [ 16504 ]
            Component/s obs_subaru [ 10747 ]
            Hide
            tjenness Tim Jenness added a comment -

            Kian-Tat Lim I added a test that broke obs_lsst (because it was erroneously returning a single amplifier) and then just combined the two distinct component reading routines into one.

            Show
            tjenness Tim Jenness added a comment - Kian-Tat Lim I added a test that broke obs_lsst (because it was erroneously returning a single amplifier) and then just combined the two distinct component reading routines into one.
            tjenness Tim Jenness made changes -
            Reviewers Kian-Tat Lim [ ktl ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            ktl Kian-Tat Lim added a comment -

            As I understand it, this is conforming the API in FitsRawFormatterBase with the new one in FitsExposureFormatter from DM-24285.

            The change and test look reasonable to accomplish this.

            Show
            ktl Kian-Tat Lim added a comment - As I understand it, this is conforming the API in FitsRawFormatterBase with the new one in FitsExposureFormatter from DM-24285 . The change and test look reasonable to accomplish this.
            ktl Kian-Tat Lim made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            tjenness Tim Jenness added a comment -

            And for the record, the raw formatter has always ignored parameters so there is no change there (we may want to fix that but for now this ticket is not the place).

            Show
            tjenness Tim Jenness added a comment - And for the record, the raw formatter has always ignored parameters so there is no change there (we may want to fix that but for now this ticket is not the place).
            tjenness Tim Jenness made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Kian-Tat Lim
              Watchers:
              Christopher Waters, Jim Bosch, Kian-Tat Lim, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: