Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24376

afw should warn when FITS headers case may be modified (cfitsio > 3380)

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      When using newer versions of CFITSIO (> 3380 aka 3.38), keys written by cfitsio via fits_write_record / ffprec are upper cased.

      When reading from FITS files, some parts of CFITSIO will uppercase header keywords but not all cases.

      afw should warn when it knows that, when writing to a file, lowercase keywords will be encountered.

      afw should also uppercase all headers on read, and possibly warn users when this has happened.

        Attachments

          Issue Links

            Activity

            Hide
            ktl Kian-Tat Lim added a comment -

            Some suggestions for possible wording improvements.

            Note that this is independent of actually upgrading cfitsio, but we should do that ASAP.

            Show
            ktl Kian-Tat Lim added a comment - Some suggestions for possible wording improvements. Note that this is independent of actually upgrading cfitsio, but we should do that ASAP.
            Hide
            bvan Brian Van Klaveren added a comment -

            I have poked around on this, and the PR has a few warnings. The warnings on read may be too verbose, but I'm not sure.

            I had some issues with jenkins but I have been able to build this on all systems in stack-os-matrix, but not in one build yet.

            Show
            bvan Brian Van Klaveren added a comment - I have poked around on this, and the PR has a few warnings. The warnings on read may be too verbose, but I'm not sure. I had some issues with jenkins but I have been able to build this on all systems in stack-os-matrix, but not in one build yet.

              People

              • Assignee:
                bvan Brian Van Klaveren
                Reporter:
                bvan Brian Van Klaveren
                Reviewers:
                Kian-Tat Lim
                Watchers:
                Brian Van Klaveren, Kian-Tat Lim, Krzysztof Findeisen
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel