Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2437

Port HSC-side functionality to allow showCamera to display real data via the butler

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      4
    • Sprint:
      Science Pipelines DM-S15-5, Science Pipelines DM-S15-6, Science Pipelines DM-W16-1
    • Team:
      Data Release Production

      Description

      One of the things that exists on the HSC side of things but not LSST is the ability to use showCamera to create full-focal-plane mosaics. Please convert the code to run with the new cameraGeom

      Not only is this generically useful, but it's part of the effort required to make the DM-side visualisation work for the Camera group

        Attachments

          Issue Links

            Activity

            Hide
            rhl Robert Lupton added a comment -

            Made to work with obs_test although as a one-ccd camera it's not very interesting.

            Also add bin/showCamera.py which plots an camera whose obs package you have setup.

            $ git merge --no-ff tickets/DM-2437
            Merge made by the 'recursive' strategy.
             bin/showCamera.py                   |  81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
             examples/Show Camera.ipynb          | 206 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
             python/lsst/afw/cameraGeom/utils.py | 201 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------
             ups/afw.table                       |   2 ++
             4 files changed, 451 insertions(+), 39 deletions(-)
             create mode 100755 bin/showCamera.py
             create mode 100644 examples/Show Camera.ipynb
            $ git push
            Counting objects: 16, done.
            Delta compression using up to 8 threads.
            Compressing objects: 100% (14/14), done.
            Writing objects: 100% (16/16), 284.04 KiB | 0 bytes/s, done.
            Total 16 (delta 8), reused 0 (delta 0)
            To git@github.com:lsst/afw
               6162e71..f3aa81e  master -> master
            

            Show
            rhl Robert Lupton added a comment - Made to work with obs_test although as a one-ccd camera it's not very interesting. Also add bin/showCamera.py which plots an camera whose obs package you have setup. $ git merge --no-ff tickets/DM-2437 Merge made by the 'recursive' strategy. bin/showCamera.py | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ examples/Show Camera.ipynb | 206 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ python/lsst/afw/cameraGeom/utils.py | 201 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------- ups/afw.table | 2 ++ 4 files changed, 451 insertions(+), 39 deletions(-) create mode 100755 bin/showCamera.py create mode 100644 examples/Show Camera.ipynb $ git push Counting objects: 16, done. Delta compression using up to 8 threads. Compressing objects: 100% (14/14), done. Writing objects: 100% (16/16), 284.04 KiB | 0 bytes/s, done. Total 16 (delta 8), reused 0 (delta 0) To git@github.com:lsst/afw 6162e71..f3aa81e master -> master
            Hide
            rhl Robert Lupton added a comment -

            Once this is resolved I can use obs_test in this ticket's example notebook.

            Show
            rhl Robert Lupton added a comment - Once this is resolved I can use obs_test in this ticket's example notebook.
            Hide
            krughoff Simon Krughoff added a comment -

            Comments on the pull request: https://github.com/lsst/afw/pull/35

            The big thing is that this change breaks another method, showCcd.

            I don't know how to test display utility code, so there was no way to know that it broke. Suggestions welcome on that front.

            Show
            krughoff Simon Krughoff added a comment - Comments on the pull request: https://github.com/lsst/afw/pull/35 The big thing is that this change breaks another method, showCcd. I don't know how to test display utility code, so there was no way to know that it broke. Suggestions welcome on that front.
            Hide
            rhl Robert Lupton added a comment -

            I finally finished up the port to showCamera that allows you to use it with the butler to generate full-focal plane (or subset) images.

            git diff --stat master
             examples/Show Camera.ipynb          |  75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
             python/lsst/afw/cameraGeom/utils.py | 163 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-----------------------
             2 files changed, 206 insertions(+), 32 deletions(-)
            

            Show
            rhl Robert Lupton added a comment - I finally finished up the port to showCamera that allows you to use it with the butler to generate full-focal plane (or subset) images. git diff --stat master examples/Show Camera.ipynb | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++++ python/lsst/afw/cameraGeom/utils.py | 163 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------- 2 files changed, 206 insertions(+), 32 deletions(-)
            Hide
            rhl Robert Lupton added a comment -

            I have this more-or-less written.

            Show
            rhl Robert Lupton added a comment - I have this more-or-less written.
            Hide
            swinbank John Swinbank added a comment -

            Adding this to the HSC port epic. It would help to identify which HSC-side tickets this corresponds to.

            Show
            swinbank John Swinbank added a comment - Adding this to the HSC port epic. It would help to identify which HSC-side tickets this corresponds to.

              People

              Assignee:
              rhl Robert Lupton
              Reporter:
              rhl Robert Lupton
              Reviewers:
              Simon Krughoff
              Watchers:
              Jim Bosch, John Swinbank, Robert Lupton, Simon Krughoff
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: