Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24447

PressureSensor model

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Build a model that connects to the ADAM and can read voltages off the analog inputs.

        Attachments

          Issue Links

            Activity

            Hide
            cwinslow Colin Winslow [X] (Inactive) added a comment -

            Created model class and a jupyter notebook to test it

             

            In the jupyter notebook you can see the ADAM reporting all analog input channels. All of them report -10V except for channel 5, which the pressure sensor is connected to

            https://github.com/lsst-ts/ts_pressureSensor/blob/master/python/lsst/ts/pressureSensor/Untitled.ipynb

            (In this notebook I also tried opening 2 connections to the same device to see if they step on each other)

             

            I am going to rework this CSC somewhat so that we can configure any combination of thermometers or pressure sensors  per ADAM device, so some of this work will be revisited

             

             

            Show
            cwinslow Colin Winslow [X] (Inactive) added a comment - Created model class and a jupyter notebook to test it   In the jupyter notebook you can see the ADAM reporting all analog input channels. All of them report -10V except for channel 5, which the pressure sensor is connected to https://github.com/lsst-ts/ts_pressureSensor/blob/master/python/lsst/ts/pressureSensor/Untitled.ipynb (In this notebook I also tried opening 2 connections to the same device to see if they step on each other)   I am going to rework this CSC somewhat so that we can configure any combination of thermometers or pressure sensors  per ADAM device, so some of this work will be revisited    
            Hide
            pingraham Patrick Ingraham added a comment -

            Please create a PR for code review. Things should be on branches and getting merged to develop, looks like you're working straight off master. 

            I see the notebook is living with the codebase which is a little odd. There is probably a better place for that? Maybe Tiago Ribeiro can mention whatever the precedent is. Filename also needs a fix.

            Show
            pingraham Patrick Ingraham added a comment - Please create a PR for code review. Things should be on branches and getting merged to develop, looks like you're working straight off master.  I see the notebook is living with the codebase which is a little odd. There is probably a better place for that? Maybe Tiago Ribeiro can mention whatever the precedent is. Filename also needs a fix.
            Hide
            tribeiro Tiago Ribeiro added a comment -

            Two suggestions, move notebook to the "examples" (https://github.com/lsst-ts/ts_pressureSensor/tree/master/examples) folder or create a "notebooks" folder in the root of the package. 

             

            Notebook will likely need some "import" statements to work. 

             

            I also suggest reverting the commits done to master, adding the changes to a branch (tickets/DM-24447) and make a PR (to develop). 

             

            Show
            tribeiro Tiago Ribeiro added a comment - Two suggestions, move notebook to the "examples" ( https://github.com/lsst-ts/ts_pressureSensor/tree/master/examples ) folder or create a "notebooks" folder in the root of the package.    Notebook will likely need some "import" statements to work.    I also suggest reverting the commits done to master, adding the changes to a branch (tickets/ DM-24447 ) and make a PR (to develop).   
            Hide
            pingraham Patrick Ingraham added a comment -

            Nearly all items in PR addressed.

            One bug slipped through that's being fixed in DM-24775.

            Show
            pingraham Patrick Ingraham added a comment - Nearly all items in PR addressed. One bug slipped through that's being fixed in DM-24775 .

              People

              Assignee:
              cwinslow Colin Winslow [X] (Inactive)
              Reporter:
              cwinslow Colin Winslow [X] (Inactive)
              Reviewers:
              Patrick Ingraham
              Watchers:
              Colin Winslow [X] (Inactive), Patrick Ingraham, Tiago Ribeiro
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.