Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24495

Convert config overrides to use file in several obs packages

    XMLWordPrintable

    Details

      Description

      As per https://community.lsst.org/t/pex-config-configs-now-know-where-they-are/4023,
      use os.path.dirname(__file__) instead of getPackageDir in obs-package config files.

      I'm doing just obs_lsst, obs_decam, and obs_subaru on this ticket because I already did the work before deciding it didn't belong as a side-commit on the ticket I was working on. Others are welcome to take care of other packages on other tickets.

        Attachments

          Activity

          Hide
          jbosch Jim Bosch added a comment -

          This is a bit of drudgery, but hopefully it'll still be an easy review for you all: I'm just changing the usage of getPackageDir to os.path.dirname(_file_), which is less dependent on EUPS, better reflects the fact that these are really relative links, not absolute ones, and is probably faster. I figured it'd be good to do essentially all of these together instead of just starting to write new configs in the new form, to avoid future confusion.

          I've assigned different reviewers for different packages:

          Show
          jbosch Jim Bosch added a comment - This is a bit of drudgery, but hopefully it'll still be an easy review for you all: I'm just changing the usage of getPackageDir to os.path.dirname(_ file _) , which is less dependent on EUPS, better reflects the fact that these are really relative links, not absolute ones, and is probably faster. I figured it'd be good to do essentially all of these together instead of just starting to write new configs in the new form, to avoid future confusion. I've assigned different reviewers for different packages: Christopher Waters : obs_lsst Meredith Rawls : obs_decam Paul Price : obs_subaru
          Hide
          mrawls Meredith Rawls added a comment -

          Neat! Thanks for the community link for context. All the changes in obs_decam are for files in the config directory which refer to other files in the config directory, so I don't see any way that could break things. That one's good to go.

          Show
          mrawls Meredith Rawls added a comment - Neat! Thanks for the community link for context. All the changes in obs_decam are for files in the config directory which refer to other files in the config directory, so I don't see any way that could break things. That one's good to go.
          Hide
          price Paul Price added a comment -

          obs_subaru looks good.

          Show
          price Paul Price added a comment - obs_subaru looks good.
          Hide
          czw Christopher Waters added a comment -

          One note about very old commented code in `config/sky.py`.  Otherwise seems fine.

          Show
          czw Christopher Waters added a comment - One note about very old commented code in `config/sky.py`.  Otherwise seems fine.

            People

            Assignee:
            jbosch Jim Bosch
            Reporter:
            jbosch Jim Bosch
            Reviewers:
            Christopher Waters, Paul Price
            Watchers:
            Christopher Waters, Jim Bosch, Meredith Rawls, Paul Price
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                CI Builds

                No builds found.