Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24515

Refactor gen3 butler.prune

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      In DM-23671 we refactored datastore deletion into a two pass trash and empty. This allows us to simplify the logic in prune.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-23671 Improve dataset deletion in Gen3 butler

          • Done

            Activity

            Ascending order - Click to sort in descending order
            No builds found.
            tjenness Tim Jenness created issue -
            tjenness Tim Jenness made changes -
            Field Original Value New Value
            Link This issue relates to DM-23671 [ DM-23671 ]
            tjenness Tim Jenness made changes -
            Component/s daf_butler [ 11300 ]
            tjenness Tim Jenness made changes -
            Labels gen3-middleware
            jbosch Jim Bosch made changes -
            Assignee Jim Bosch [ jbosch ]
            jbosch Jim Bosch made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            I'm going to take a quick shot at this before proceeding with the dataset table refactor so I can have a bit more confidence in the dataset-deletion APIs I'll be moving around there.

            Show
            jbosch Jim Bosch added a comment - I'm going to take a quick shot at this before proceeding with the dataset table refactor so I can have a bit more confidence in the dataset-deletion APIs I'll be moving around there.
            jbosch Jim Bosch made changes -
            Team Architecture [ 10304 ] Data Release Production [ 10301 ]
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            This goes a bit beyond the original ticket description, because I wanted to do a bit more work to simplify and clarify interfaces prior to the dataset table refactor on DM-21764.

            Andy Salnikov, I hope you don't mind reviewing, even if you haven't been following the deletion discussions too closely - I don't think that will matter much here - as I've been hitting Tim Jenness pretty hard with reviews lately.

            Show
            jbosch Jim Bosch added a comment - This goes a bit beyond the original ticket description, because I wanted to do a bit more work to simplify and clarify interfaces prior to the dataset table refactor on DM-21764 . Andy Salnikov , I hope you don't mind reviewing, even if you haven't been following the deletion discussions too closely - I don't think that will matter much here - as I've been hitting Tim Jenness pretty hard with reviews lately.
            jbosch Jim Bosch made changes -
            Reviewers Andy Salnikov [ salnikov ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Jira has spotted the tiny ctrl_mpexec PR, but not the daf_butler one, so here it is: https://github.com/lsst/daf_butler/pull/261.

            Show
            jbosch Jim Bosch added a comment - Jira has spotted the tiny ctrl_mpexec PR, but not the daf_butler one, so here it is: https://github.com/lsst/daf_butler/pull/261 .
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Sure, will look at it later today when I'm done with one qserv review.

            Show
            salnikov Andy Salnikov added a comment - Sure, will look at it later today when I'm done with one qserv review.
            Hide
            Permalink
            salnikov Andy Salnikov added a comment -

            Looks good, few minor comments.

            Show
            salnikov Andy Salnikov added a comment - Looks good, few minor comments.
            salnikov Andy Salnikov made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            jbosch Jim Bosch made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            tjenness Tim Jenness made changes -
            Story Points 2
            swinbank John Swinbank made changes -
            Epic Link DM-23737 [ 431393 ]

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Andy Salnikov
              Watchers:
              Andy Salnikov, Jim Bosch, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.