Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24523

ap.verify.ingestion._findMatchingFiles excludes directories

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: ap_verify
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      AP S20-5 (April)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      As reported on Community, the unit tests for ap_verify include a test where the _findMatchingFiles function searches for files that don't contain the string "fr". This test causes a false positive when run in a directory containing "fr". Fix _findMatchingFiles so that exclude patterns are matched only against the filename, as implied by the documentation.

        Attachments

          Issue Links

            Activity

            Hide
            price Paul Price added a comment -

            LGTM.

            John Swinbank, this bug prevents building LSST v19, so this fix is a candidate for a patch release.

            Show
            price Paul Price added a comment - LGTM. John Swinbank , this bug prevents building LSST v19, so this fix is a candidate for a patch release.

              People

              Assignee:
              krzys Krzysztof Findeisen
              Reporter:
              krzys Krzysztof Findeisen
              Reviewers:
              Paul Price
              Watchers:
              Krzysztof Findeisen, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.