Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24559

write_curated_calibrations is not passing the butler registry to getInstrument

    XMLWordPrintable

    Details

    • Story Points:
      6
    • Sprint:
      DB_S20_02
    • Team:
      Data Access and Database
    • Urgent?:
      No

      Description

      instr = getInstrument(instrument)
      

      should be 

      instr = getInstrument(instrument, butler.registry)
      

      like in register_instrument

      Make that change, and add a test to obs_base like the ingest_tests.py that obs packages can run to ensure that these commands work. At the moment it can run create -> register-instrument -> write-curated-calibrations and ensure they work (with write-curated-calirations using the name not the class).

      Also add a test_cli.py file to each obs package specfiying the instrument class, e.g. make obs_decam/subaru/lsst have a trivial test file that inherits from it and specifies the instrument class to use.

       

      Found during development of the test, the docstrings in obs_base utils.py getInstrument.py and instrument_option are wrong and should indicate "canonical name of the instrument or the fully qualified Instrument class name".

        Attachments

          Activity

          There are no comments yet on this issue.

            People

            Assignee:
            npease Nate Pease
            Reporter:
            npease Nate Pease
            Reviewers:
            Jim Bosch
            Watchers:
            Jim Bosch, Nate Pease
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                CI Builds

                No builds found.