Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24618

Fix leftover case warnings from FITS changes

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      Running processCcd.py is  producing afw.fits WARN: In void lsst::afw::fits::{anonymous}::writeKeyFromProperty(lsst::afw::fits::Fits&, const lsst::daf::base::PropertySet&, const string&, const char*), key 'ext_photometryKron_KronFlux_nRadiusForFlux' may be standardized to uppercase 'EXT_PHOTOMETRYKRON_KRONFLUX_NRADIUSFORFLUX' on write. errors.

      Fix this.

        Attachments

          Issue Links

            Activity

            Hide
            erykoff Eli Rykoff added a comment -

            I was just realizing that there are the two different problems here (which Merlin Fisher-Levine was alluding to). The read warnings should just be DEBUG, I agree, since we aren't going to update the catalogs. But the write errors (such as the canonical one in the ticket description) need to be fixed "upstream".

            Show
            erykoff Eli Rykoff added a comment - I was just realizing that there are the two different problems here (which Merlin Fisher-Levine was alluding to). The read warnings should just be DEBUG, I agree, since we aren't going to update the catalogs. But the write errors (such as the canonical one in the ticket description) need to be fixed "upstream".
            Hide
            bvan Brian Van Klaveren added a comment -

            WARN to DEBUG case conversion messages when reading has been split off to DM-24993

            Show
            bvan Brian Van Klaveren added a comment - WARN to DEBUG case conversion messages when reading has been split off to DM-24993
            Hide
            swinbank John Swinbank added a comment - - edited

            Hey folks — Kian-Tat Lim is going to do a push to resolve the warnings mentioned on this ticket before the end of this week (so the fixes will be in w_2020_21). He will not audit the codebase to catch other warnings which haven't been mentioned. If you are fighting warnings which aren't captured in the above, please add them to this ticket within the next couple of hours so we can be sure they'll be resolved.

            Show
            swinbank John Swinbank added a comment - - edited Hey folks —  Kian-Tat Lim is going to do a push to resolve the warnings mentioned on this ticket before the end of this week (so the fixes will be in w_2020_21 ). He will not audit the codebase to catch other warnings which haven't been mentioned. If you are fighting warnings which aren't captured in the above, please add them to this ticket within the next couple of hours so we can be sure they'll be resolved.
            Hide
            ktl Kian-Tat Lim added a comment -

            If my searching is correct, most of the warnings complained about above are on read, and those are fixed by DM-24993, now merged. The remaining write problems seem to be in photometryKron, and I am testing a PR that will fix them.

            Show
            ktl Kian-Tat Lim added a comment - If my searching is correct, most of the warnings complained about above are on read, and those are fixed by DM-24993 , now merged. The remaining write problems seem to be in photometryKron , and I am testing a PR that will fix them.
            Hide
            ktl Kian-Tat Lim added a comment -

            Jenkins ran successfully (lsst_distrib and lsst_ci only, not ci_hsc). Looking through all the logs, there are no uppercase warnings from image writing or reading. There are warnings from meas_algorithms about CALIBDATE, CALIB_CREATION_DATE, and CALIB_CREATION_TIME metadata items for curves (which I think are persisted as tables via astropy, not our own code), but those are for length and string content, not case.

            Show
            ktl Kian-Tat Lim added a comment - Jenkins ran successfully (lsst_distrib and lsst_ci only, not ci_hsc). Looking through all the logs, there are no uppercase warnings from image writing or reading. There are warnings from meas_algorithms about CALIBDATE , CALIB_CREATION_DATE , and CALIB_CREATION_TIME metadata items for curves (which I think are persisted as tables via astropy, not our own code), but those are for length and string content, not case.

              People

              • Assignee:
                ktl Kian-Tat Lim
                Reporter:
                mfisherlevine Merlin Fisher-Levine
                Reviewers:
                Eli Rykoff
                Watchers:
                Brian Van Klaveren, Eli Rykoff, John Parejko, John Swinbank, Kian-Tat Lim, Lauren MacArthur, Merlin Fisher-Levine, Yusra AlSayyad
              • Votes:
                0 Vote for this issue
                Watchers:
                8 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Summary Panel