Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24705

Remove afwGeom aliases for geom from pipe_analysis

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: pipe_analysis
    • Labels:
      None
    • Story Points:
      1
    • Epic Link:
    • Sprint:
      DRP S20-5 (Apr), DRP S20-6 (May)
    • Team:
      Data Release Production
    • Urgent?:
      No

      Description

      Many of the afwGeom aliases (e.g. [Sphere]Point, Extent, angular units) are now deprecated in favor of those defined in geom.  Please replace all instances in the pipe_analysis scripts.

        Attachments

          Issue Links

          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20565 Remove afwGeom aliases for geom

          • Done

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-20566 Remove aliased afwGeom geom usage from stack

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            lauren Lauren MacArthur added a comment - - edited

            Seeing as you just made some similar fixes, would you mind giving this a look?  All scripts now run without error and PR is here

            Oh, and FYI, the only two remaining lsst.afw.geom calls are to afwGeom.Quadrupole and afwGeom.ellipses.

            Show
            lauren Lauren MacArthur added a comment - - edited Seeing as you just made some similar fixes, would you mind giving this a look?  All scripts now run without error and PR is here Oh, and FYI, the only two remaining  lsst.afw.geom calls are to  afwGeom.Quadrupole and afwGeom.ellipses .
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            This adds an import of daf.persistence that I don't think is necessary. Other than that, looks good!

            Show
            swinbank John Swinbank added a comment - This adds an import of daf.persistence that I don't think is necessary. Other than that, looks good!
            Hide
            Permalink
            lauren Lauren MacArthur added a comment -

            Thanks John!  Superfluous import removed, rebased, and merged to master.

            Show
            lauren Lauren MacArthur added a comment - Thanks John!  Superfluous import removed, rebased, and merged to master.

              People

              Assignee:
              lauren Lauren MacArthur
              Reporter:
              lauren Lauren MacArthur
              Reviewers:
              John Swinbank
              Watchers:
              John Swinbank, Lauren MacArthur, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.