Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: None
-
Labels:
-
Story Points:32
-
Epic Link:
-
Team:Data Release Production
-
Urgent?:No
Description
In addition to Kron and CModel photometry, this ticket proposes to implement GAaP photometry (Kuijken 2008). For extended objects (galaxies), GAaP is not designed to give accurate fluxes, but provides accurate and robust colors. This ticket is a master-ticket to contain multiple tickets related to this work.
Attachments
Issue Links
- contains
-
DM-24686 Make a single Gaussian PSF matched coadd
- Done
-
DM-24691 Implement GaussianFlux with sinc coefficients
- Done
- is blocked by
-
DM-29256 Error reading in Quantum Graph with measurement config
- To Do
- relates to
-
DM-28024 Create initial meas_extenstions_gaap
- Done
-
DM-28740 Remove the NaN values in PSF-matched exposure for GAaP
- Done
-
DM-28925 Truncate BBox growth for source near the edges
- Done
-
DM-28955 Allow passing `alardSigGauss` parameter to `modelPsfMatch` task at runtime
- Done
I'm done reviewing, and while I've left a ton of comments on the PR, overall I think this looks pretty good, and the volume of comments just reflects this being your first big PR and the fact that it's in a sort of crusty part of the codebase (measurement plugins), where our best examples are sort of fossilized relative to modern style.
I've looked through all of this pretty throughly, so one approach to splitting up with the review with Yusra AlSayyad might be for her to take the second pass, after you think you've addressed my comments?