Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2476

remove afw.image.utils.clipImage

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: To Do
    • Resolution: Unresolved
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
    • Team:
      Data Release Production

      Description

      The function lsst.afw.image.utils.clipImage was broken and is not used anywhere. I fixed it just enough to make the pyflakes linter happy (work on tickets/DM-2471 that I expect to have merged in a day or two), but it should be removed.

        Attachments

          Issue Links

          mentioned in

          Page Loading...

          Page Loading...

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            swinbank John Swinbank added a comment -

            If this function was broken and continues to be unused, is it necessary at all? Can we simply drop it?

            Show
            swinbank John Swinbank added a comment - If this function was broken and continues to be unused, is it necessary at all? Can we simply drop it?
            Hide
            Permalink
            rhl Robert Lupton added a comment -

            The function clips an image to lie in (min, max). It seems useful enough to keep.

            Show
            rhl Robert Lupton added a comment - The function clips an image to lie in (min, max). It seems useful enough to keep.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            I can confirm that there is still no unit test for clipImage and it's not used anywhere in lsst_distrib.

            Show
            tjenness Tim Jenness added a comment - I can confirm that there is still no unit test for clipImage and it's not used anywhere in lsst_distrib.
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Edited to recommend removal. It's been 7 years, it's apparently broken, and it's trivial to do with numpy (and that's what 99%) of our devs would reach for first.

            Show
            jbosch Jim Bosch added a comment - Edited to recommend removal. It's been 7 years, it's apparently broken, and it's trivial to do with numpy (and that's what 99%) of our devs would reach for first.

              People

              Assignee:
              Unassigned Unassigned
              Reporter:
              rowen Russell Owen
              Watchers:
              Jim Bosch, John Swinbank, Lee Kelvin, Robert Lupton, Russell Owen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

                Dates

                Created:
                Updated:

                  Jenkins

                  No builds found.