Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24766

Update ts_ATDome to use port=0 instead of a port generator when talking to the mock controller

    Details

      Description

      At present ts_ATDome uses a generator to pick a likely-free port when running unit tests. This is not really safe. It is much better to specify port=0 and let the operating system pick a free port (as ts_hexrotcomm does in OneClientServer). Update ts_ATDome accordingly.

        Attachments

          Activity

          Hide
          wvreeven Wouter van Reeven added a comment -

          All changes accepted.

          Show
          wvreeven Wouter van Reeven added a comment - All changes accepted.
          Hide
          rowen Russell Owen added a comment -

          Pull request: https://github.com/lsst-ts/ts_ATDome/pull/24

          As Wouter noted on github, the new flake8 has exposed some issues (f strings with no {}) so I will have to fix those.

          Show
          rowen Russell Owen added a comment - Pull request: https://github.com/lsst-ts/ts_ATDome/pull/24 As Wouter noted on github, the new flake8 has exposed some issues (f strings with no {}) so I will have to fix those.
          Hide
          rowen Russell Owen added a comment -

          Merged to develop and master and released as v1.1.2. New documentation uploaded to https://ts-atdome.lsst.io

          Show
          rowen Russell Owen added a comment - Merged to develop and master and released as v1.1.2. New documentation uploaded to https://ts-atdome.lsst.io

            People

            • Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Wouter van Reeven
              Watchers:
              Russell Owen, Wouter van Reeven
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: