Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2492

shapelet unit tests attempts to access display on failure

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: shapelet
    • Labels:
      None

      Description

      When tests/profiles.py tests fail, they attempt to create live plots without checking for any variables that indicate that the display should be used.

      These plots should be disabled, as they obscure the real error when the display is not available.

        Attachments

          Issue Links

          blocks

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-2493 prepare v10_1_rc3 release candidate

          • Done
          relates to

          Story - Created by Jira Software - do not edit or delete. Issue type for a user story. DM-2494 more shapelet unsanctioned access to display

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            jbosch Jim Bosch added a comment -

            Tim Jenness, as a bystander for the reporting of this bug, would you care to review?

            All changes in tickets/DM-2492 branches of shapelet, and all are trivial changes of "plotOnFailure=True" to "plotOnFailure=False".

            If you're curious about where the assertClose method comes from, it's in the utils package, in tests.py.

            Show
            jbosch Jim Bosch added a comment - Tim Jenness , as a bystander for the reporting of this bug, would you care to review? All changes in tickets/ DM-2492 branches of shapelet, and all are trivial changes of "plotOnFailure=True" to "plotOnFailure=False". If you're curious about where the assertClose method comes from, it's in the utils package, in tests.py.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            Looks good to me.

            Show
            tjenness Tim Jenness added a comment - Looks good to me.
            Hide
            Permalink
            tjenness Tim Jenness added a comment -

            This patch is a minor change and looks to be correct.

            Show
            tjenness Tim Jenness added a comment - This patch is a minor change and looks to be correct.
            Hide
            Permalink
            frossie Frossie Economou added a comment -

            Blocker requested by Jim Bosch accepted by Frossie Economou

            Show
            frossie Frossie Economou added a comment - Blocker requested by Jim Bosch accepted by Frossie Economou

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Tim Jenness
              Watchers:
              Frossie Economou, Jim Bosch, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.