Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-2492

shapelet unit tests attempts to access display on failure

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: shapelet
    • Labels:
      None

      Description

      When tests/profiles.py tests fail, they attempt to create live plots without checking for any variables that indicate that the display should be used.

      These plots should be disabled, as they obscure the real error when the display is not available.

        Attachments

          Issue Links

            Activity

            No builds found.
            jbosch Jim Bosch created issue -
            Hide
            jbosch Jim Bosch added a comment -

            Tim Jenness, as a bystander for the reporting of this bug, would you care to review?

            All changes in tickets/DM-2492 branches of shapelet, and all are trivial changes of "plotOnFailure=True" to "plotOnFailure=False".

            If you're curious about where the assertClose method comes from, it's in the utils package, in tests.py.

            Show
            jbosch Jim Bosch added a comment - Tim Jenness , as a bystander for the reporting of this bug, would you care to review? All changes in tickets/ DM-2492 branches of shapelet, and all are trivial changes of "plotOnFailure=True" to "plotOnFailure=False". If you're curious about where the assertClose method comes from, it's in the utils package, in tests.py.
            jbosch Jim Bosch made changes -
            Field Original Value New Value
            Reviewers Tim Jenness [ tjenness ]
            Status To Do [ 10001 ] In Review [ 10004 ]
            Hide
            tjenness Tim Jenness added a comment -

            Looks good to me.

            Show
            tjenness Tim Jenness added a comment - Looks good to me.
            Hide
            tjenness Tim Jenness added a comment -

            This patch is a minor change and looks to be correct.

            Show
            tjenness Tim Jenness added a comment - This patch is a minor change and looks to be correct.
            tjenness Tim Jenness made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            jbosch Jim Bosch made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            Hide
            frossie Frossie Economou added a comment -

            Blocker requested by Jim Bosch accepted by Frossie Economou

            Show
            frossie Frossie Economou added a comment - Blocker requested by Jim Bosch accepted by Frossie Economou
            frossie Frossie Economou made changes -
            Link This issue blocks DM-2493 [ DM-2493 ]
            jbosch Jim Bosch made changes -
            Link This issue relates to DM-2494 [ DM-2494 ]
            swinbank John Swinbank made changes -
            Epic Link DM-1910 [ 15942 ]

              People

              Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Tim Jenness
              Watchers:
              Frossie Economou, Jim Bosch, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.