Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-24937

move implementation of remaining butler commands to script folder

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Sprint:
      DB_S20_02
    • Team:
      Data Access and Database
    • Urgent?:
      No

      Description

      the butler command functions config_dump and config_validate need to be refactored so that their implementations are in the scripts folder, similar to the other command functions.

        Attachments

          Activity

          Hide
          npease Nate Pease added a comment -

          Tim, can you please take a look? This finishes the issues raised in the review of DM-24584.

          Show
          npease Nate Pease added a comment - Tim, can you please take a look? This finishes the issues raised in the review of DM-24584 .
          Hide
          tjenness Tim Jenness added a comment -

          Looks good to me. I am happy with you using the click wrappers in the tests. Does pytest handle errors okay with a full stack trace if an unexpected failure happens inside one of those commands?

          Show
          tjenness Tim Jenness added a comment - Looks good to me. I am happy with you using the click wrappers in the tests. Does pytest handle errors okay with a full stack trace if an unexpected failure happens inside one of those commands?

            People

            Assignee:
            npease Nate Pease
            Reporter:
            npease Nate Pease
            Reviewers:
            Tim Jenness
            Watchers:
            Nate Pease, Tim Jenness
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                CI Builds

                No builds found.