# Rework testdata_jointcal dependencies

XMLWordPrintable

## Details

• Type: Improvement
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s:
• Labels:
None
• Story Points:
1
• Sprint:
AP S20-6 (May)
• Team:

## Description

The new data in DM-17597 will grow the size of a testdata_jointcal checkout significantly. Because testdata_jointcal has dependencies on each of the obs packages that it contains data for, it is re-installed during every build, resulting in potentially significant disk usage.

This ticket is to split out the obs dependencies so that testdata_jointcal has no dependencies itself. jointcal and fgcmcal would then gain optional dependencies on the obs packages whose repos they use, in addition to testdata_jointcal. Those unittests would also need to trip for whether the appropriate obs packages was setup and skip the tests if not.

As part of this, we should add a note to fgcmcal.table to explain why it has a dependency on jointcal (it needs the gen2 tract-grouping code, which will be unnecessary in gen3).

## Activity

Hide
John Parejko added a comment - - edited
Show
John Parejko added a comment - - edited Jenkins (first run got a 500 error on macos): https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/31908/pipeline
Hide
John Parejko added a comment -

Tim Jenness: do you mind doing this short review, since we had discussed the idea earlier?

Eli Rykoff: are you ok with this change to fgcmcal, and do my docs on testdata_jointcal make sense to yoU?

Show
John Parejko added a comment - Tim Jenness : do you mind doing this short review, since we had discussed the idea earlier? Eli Rykoff : are you ok with this change to fgcmcal, and do my docs on testdata_jointcal make sense to yoU?
Hide
Tim Jenness added a comment -

Looks good. The only substantive comment is to switch from pex_exceptions to LookupError everywhere.

Show
Tim Jenness added a comment - Looks good. The only substantive comment is to switch from pex_exceptions to LookupError everywhere.
Hide
John Parejko added a comment -

Thank you for the comments. I cleaned up the exception handling, and ran jenkins again and it was clear.

Merged and done.

Show
John Parejko added a comment - Thank you for the comments. I cleaned up the exception handling, and ran jenkins again and it was clear. Merged and done.

## People

• Assignee:
John Parejko
Reporter:
John Parejko
Reviewers:
Tim Jenness
Watchers:
Eli Rykoff, John Parejko, John Swinbank, Tim Jenness