Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-25184

Make obs_subaru config overrides play nice with new jointcal filterMap config

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: jointcal, obs_subaru
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      AP F20-1 (June)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      Monika Adamow 3:37 PM:
      When I try to run

       jointcal.py /datasets/hsc/repo --calib /datasets/hsc/repo/CALIB --rerun RC/w_2020_22/DM-25176-sfm:RC/w_2020_22/DM-25176 --id ccd=0..8^10..103 visit=26024^26028^26032^26036^26044^26046^26048^26050^26058^26060^26062^26070^26072^26074^26080^26084^26094 filter=HSC-G tract=9615
      

      with w_2020_22 I get

      jointcal.Associations INFO: Unmatched objects: 2
      jointcal.Associations INFO: Matched 49 objects in 26094_103
      jointcal.Associations INFO: Unmatched objects: 2
      jointcal FATAL: Failed processing tract 9615, RuntimeError: Unknown reference filter phot_g_mean_flux
      

      Lauren MacArthur 3:45 PM
      I think that’s the gaia flux column, but is HSC still using ps1 for jointcal (astrom)?

      Lauren MacArthur 3:57 PM
      The filterMap is now getting loaded with the gaia entries:
      in /datasets/hsc/repo/rerun/RC/w_2020_22/DM-25176/config/jointcal.py

      1. Mapping of camera filter name: reference catalog filter name; each reference filter must exist
        config.astrometryRefObjLoader.filterMap= {'u': 'phot_g_mean', 'g': 'phot_g_mean', 'r': 'phot_g_mean', 'i': 'phot _g_mean', 'z': 'phot_g_mean', 'y': 'phot_g_mean', 'B': 'g', 'V': 'r', 'R': 'r', 'I': 'i', 'r2': 'r', 'i2': 'i', 'N387': 'g', 'N468': 'g', 'N515': 'g', 'N527': 'g', 'N656': 'r', 'N718': 'i', 'N816': 'i', 'N921': 'z', 'N926' : 'z', 'N973': 'y', 'N1010': 'y', 'I945': 'z', 'HSC-G': 'g', 'HSC-R': 'r', 'HSC-R2': 'r', 'HSC-I': 'i', 'HSC-I2 ': 'i', 'HSC-Z': 'z', 'HSC-Y': 'y', 'NB0387': 'g', 'NB0468': 'g', 'NB0515': 'g', 'NB0527': 'g', 'NB0656': 'r', 'NB0718': 'i', 'NB0816': 'i', 'NB0921': 'z', 'NB0926': 'z', 'NB0973': 'y', 'NB1010': 'y', 'IB0945': 'z'}
      2. Name of the ingested reference dataset
        config.astrometryRefObjLoader.ref_dataset_name='ps1_pv3_3pi_20170110'
        vs. /datasets/hsc/repo/rerun/RC/w_2020_19/DM-24822/config/jointcal.py
      3. Mapping of camera filter name: reference catalog filter name; each reference filter must exist
        config.photometryRefObjLoader.filterMap= {'B': 'g', 'V': 'r', 'R': 'r', 'I': 'i', 'r2': 'r', 'i2': 'i', 'N387': 'g', 'N468': 'g', 'N515': 'g', 'N527': 'g', 'N656': 'r', 'N718': 'i', 'N816': 'i', 'N921': 'z', 'N926': 'z', 'N 973': 'y', 'N1010': 'y', 'I945': 'z', 'HSC-G': 'g', 'HSC-R': 'r', 'HSC-R2': 'r', 'HSC-I': 'i', 'HSC-I2': 'i', ' HSC-Z': 'z', 'HSC-Y': 'y', 'NB0387': 'g', 'NB0468': 'g', 'NB0515': 'g', 'NB0527': 'g', 'NB0656': 'r', 'NB0718': 'i', 'NB0816': 'i', 'NB0921': 'z', 'NB0926': 'z', 'NB0973': 'y', 'NB1010': 'y', 'IB0945': 'z'}
      4. Name of the ingested reference dataset
        config.photometryRefObjLoader.ref_dataset_name='ps1_pv3_3pi_20170110'

      3:57
      Ah, I think it’s appending to this (now added by default) list:
      https://github.com/lsst/jointcal/commit/41e890198605efd737f5d0b3035ce6271dad9c1c

      Lauren MacArthur 4:02 PM
      ^^ @parejkoj: it looks like that default is not safe if astrometryRefObjLoader.ref_dataset_name gets overridden (or perhaps obs_* packages have to be careful about appending vs. setting?

      John Parejko 1 hour ago
      Monika Adamow: I haven’t tested it yet, but I think you can add this at obs_subaru/config/jointcal.py:10:
      config.astrometryRefObjLoader.filterMap = {}
      (edited)

        Attachments

          Issue Links

            Activity

            Show
            Parejkoj John Parejko added a comment - Jenkins run: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/32015/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            Yusra AlSayyad: you said you'd be able to give a quick review? I have a jenkins run going now, but I was able to reproduce the problem with the new jointcal test, and confirm that my change to obs_subaru fixed it. I also cleared the photometry filterMap just to be thorough.

            Show
            Parejkoj John Parejko added a comment - Yusra AlSayyad : you said you'd be able to give a quick review? I have a jenkins run going now, but I was able to reproduce the problem with the new jointcal test, and confirm that my change to obs_subaru fixed it. I also cleared the photometry filterMap just to be thorough.
            Hide
            yusra Yusra AlSayyad added a comment -

            Monika's "how to reproduce" above works with your ticket branches. yay
            OK to merge as is; we need this tonight.

            Thoughts for the future: I don't get why jointcal needs to treat filterMaps differently than than the ~15 other places we use reference catalogs. I don't think I agree with your inline comment that there is a camera-agnostic "reasonable" filter map

            For a nice extra touch maybe add an inline comment above: config.astrometryRefObjLoader.filterMap = {} explaining that .load appends and there's a default filterMap here to blow away.

            Show
            yusra Yusra AlSayyad added a comment - Monika's "how to reproduce" above works with your ticket branches. yay OK to merge as is; we need this tonight. Thoughts for the future: I don't get why jointcal needs to treat filterMaps differently than than the ~15 other places we use reference catalogs. I don't think I agree with your inline comment that there is a camera-agnostic "reasonable" filter map For a nice extra touch maybe add an inline comment above: config.astrometryRefObjLoader.filterMap = { } explaining that .load appends and there's a default filterMap here to blow away.
            Hide
            Parejkoj John Parejko added a comment -

            Sorry about the trouble and thank you for the quick review.

            Merged and done.

            Show
            Parejkoj John Parejko added a comment - Sorry about the trouble and thank you for the quick review. Merged and done.

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              yusra Yusra AlSayyad
              Reviewers:
              Yusra AlSayyad
              Watchers:
              John Parejko, Lauren MacArthur, Monika Adamow, Yusra AlSayyad
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.