Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-25204

Update code for changes to simactautors

    XMLWordPrintable

    Details

    • Story Points:
      2
    • Epic Link:
    • Sprint:
      TSSW Sprint - May 25 - Jun 08
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      DM-25179 introduces some breaking changes to ts_simactuators. Update other code accordingly.

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-25179 Add circular mock actuators to ts_simactuators

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            Pull requests:

            Show
            rowen Russell Owen added a comment - - edited Pull requests: https://github.com/lsst-ts/ts_ATDome/pull/27 https://github.com/lsst-ts/ts_hexapod/pull/18
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            I changed the two packages that were using PointToPointActuator. The changes were pretty minor.

            I also tested ts_rotator and ts_ATMCSSimulator, both of which use TrackingActuator and, as expected, neither needed any changes.

            Finally, I took advantage of the opportunity to remove all use of astropy Angles from ts_ATDome. I feel it was a big improvement, because I was not using any of the Angle features except wrapping, and salobj now provides wrapping functions.

            Show
            rowen Russell Owen added a comment - - edited I changed the two packages that were using PointToPointActuator. The changes were pretty minor. I also tested ts_rotator and ts_ATMCSSimulator, both of which use TrackingActuator and, as expected, neither needed any changes. Finally, I took advantage of the opportunity to remove all use of astropy Angles from ts_ATDome. I feel it was a big improvement, because I was not using any of the Angle features except wrapping, and salobj now provides wrapping functions.
            Hide
            Permalink
            wvreeven Wouter van Reeven added a comment -

            The code changes look good to me.

             

            Show
            wvreeven Wouter van Reeven added a comment - The code changes look good to me.  
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Released ts_ATDome v1.2.0 and ts_hexapod v0.6.0

            Show
            rowen Russell Owen added a comment - Released ts_ATDome v1.2.0 and ts_hexapod v0.6.0

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              rowen Russell Owen
              Reviewers:
              Wouter van Reeven
              Watchers:
              Russell Owen, Wouter van Reeven
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.