Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-25316

Apply proper motion in AstrometryTask when loading refcats

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Sprint:
      AP F20-2 (July), AP F20-3 (August)
    • Team:
      Alert Production

      Description

      While investigating for DM-24277, I learned that the stack does not apply the refcat proper motion data during the single frame AstrometryTask. The only task that currently passes the exposure epoch when loading the refcat is DirectMatchTask, which is only used for photometry. I think the solution is to pass the epoch in RefMatchTask, but I will have to check for other places that use loadSkyCircle and/or loadPixelBox to be sure.

      It looks like we have no direct unittests of RefMatchTask, so any tests of this will have to live in tests of some higher level task (MatchPessimisticB? AstrometryTask?). We'll have to see whether we have an appropriate test refcat, or else create, extract, or mock one to have the relevant fields (at minimum, pm_ra, pm_dec, pm_raErr, pm_decErr).

        Attachments

          Issue Links

            Activity

            Hide
            Parejkoj John Parejko added a comment -

            Sprint planning suggests to keep this tightly boxed to only a couple days work, and to run ap_verify to check metrics before merging.

            Show
            Parejkoj John Parejko added a comment - Sprint planning suggests to keep this tightly boxed to only a couple days work, and to run ap_verify to check metrics before merging.
            Hide
            Parejkoj John Parejko added a comment -

            This work is being done on DM-28258.

            Show
            Parejkoj John Parejko added a comment - This work is being done on DM-28258 .

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Chris Morrison [X] (Inactive), Jim Bosch, John Parejko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.