Details
-
Type:
Improvement
-
Status: Invalid
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: meas_algorithms, meas_astrom
-
Labels:None
-
Story Points:4
-
Epic Link:
-
Sprint:AP F20-2 (July), AP F20-3 (August)
-
Team:Alert Production
Description
While investigating for DM-24277, I learned that the stack does not apply the refcat proper motion data during the single frame AstrometryTask. The only task that currently passes the exposure epoch when loading the refcat is DirectMatchTask, which is only used for photometry. I think the solution is to pass the epoch in RefMatchTask, but I will have to check for other places that use loadSkyCircle and/or loadPixelBox to be sure.
It looks like we have no direct unittests of RefMatchTask, so any tests of this will have to live in tests of some higher level task (MatchPessimisticB? AstrometryTask?). We'll have to see whether we have an appropriate test refcat, or else create, extract, or mock one to have the relevant fields (at minimum, pm_ra, pm_dec, pm_raErr, pm_decErr).
Attachments
Issue Links
- is duplicated by
-
DM-28258 Epoch is not getting passed consistently among reference catalog loading functions
- Done
Activity
Story Points | 2 | 4 |
Epic Link |
|
Sprint | AP F20-2 (July) [ 1025 ] |
Assignee | John Parejko [ parejkoj ] |
Sprint | AP F20-2 (July) [ 1025 ] | AP F20-2 (July), AP F20-3 (August) [ 1025, 1033 ] |
Sprint | AP F20-2 (July), AP F20-3 (August) [ 1025, 1033 ] | AP F20-2 (July), AP F20-3 (August), AP F20-4 (September) [ 1025, 1033, 1039 ] |
Sprint | AP F20-2 (July), AP F20-3 (August), AP F20-4 (September) [ 1025, 1033, 1039 ] | AP F20-2 (July), AP F20-3 (August) [ 1025, 1033 ] |
Rank | Ranked higher |
Resolution | Done [ 10000 ] | |
Status | To Do [ 10001 ] | Invalid [ 11005 ] |
Sprint planning suggests to keep this tightly boxed to only a couple days work, and to run ap_verify to check metrics before merging.