Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-25316

Apply proper motion in AstrometryTask when loading refcats

    XMLWordPrintable

    Details

    • Story Points:
      4
    • Sprint:
      AP F20-2 (July), AP F20-3 (August)
    • Team:
      Alert Production

      Description

      While investigating for DM-24277, I learned that the stack does not apply the refcat proper motion data during the single frame AstrometryTask. The only task that currently passes the exposure epoch when loading the refcat is DirectMatchTask, which is only used for photometry. I think the solution is to pass the epoch in RefMatchTask, but I will have to check for other places that use loadSkyCircle and/or loadPixelBox to be sure.

      It looks like we have no direct unittests of RefMatchTask, so any tests of this will have to live in tests of some higher level task (MatchPessimisticB? AstrometryTask?). We'll have to see whether we have an appropriate test refcat, or else create, extract, or mock one to have the relevant fields (at minimum, pm_ra, pm_dec, pm_raErr, pm_decErr).

        Attachments

          Issue Links

            Activity

            Parejkoj John Parejko created issue -
            Parejkoj John Parejko made changes -
            Field Original Value New Value
            Link This issue relates to DM-24277 [ DM-24277 ]
            Parejkoj John Parejko made changes -
            Story Points 2 4
            swinbank John Swinbank made changes -
            Epic Link DM-25139 [ 435257 ]
            swinbank John Swinbank made changes -
            Sprint AP F20-2 (July) [ 1025 ]
            swinbank John Swinbank made changes -
            Assignee John Parejko [ parejkoj ]
            swinbank John Swinbank made changes -
            Sprint AP F20-2 (July) [ 1025 ] AP F20-2 (July), AP F20-3 (August) [ 1025, 1033 ]
            sullivan Ian Sullivan made changes -
            Sprint AP F20-2 (July), AP F20-3 (August) [ 1025, 1033 ] AP F20-2 (July), AP F20-3 (August), AP F20-4 (September) [ 1025, 1033, 1039 ]
            swinbank John Swinbank made changes -
            Epic Link DM-25139 [ 435257 ] DM-26810 [ 439762 ]
            sullivan Ian Sullivan made changes -
            Sprint AP F20-2 (July), AP F20-3 (August), AP F20-4 (September) [ 1025, 1033, 1039 ] AP F20-2 (July), AP F20-3 (August) [ 1025, 1033 ]
            sullivan Ian Sullivan made changes -
            Rank Ranked higher
            sullivan Ian Sullivan made changes -
            Epic Link DM-26810 [ 439762 ] DM-27906 [ 442554 ]
            Parejkoj John Parejko made changes -
            Link This issue is duplicated by DM-28258 [ DM-28258 ]
            Parejkoj John Parejko made changes -
            Link This issue relates to DM-27013 [ DM-27013 ]
            Parejkoj John Parejko made changes -
            Resolution Done [ 10000 ]
            Status To Do [ 10001 ] Invalid [ 11005 ]

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Watchers:
              Chris Morrison [X] (Inactive), Jim Bosch, John Parejko
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.