Details

    • Type: Technical task
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      1
    • Sprint:
      Science Pipelines DM-S15-2, Science Pipelines DM-S15-3, Science Pipelines DM-S15-4
    • Team:
      Data Release Production

      Description

      Remove the Schema attribute and its getters and setters.

      This change won't be something we can merge to master on its own, as it doesn't provide backwards-compatible FITS reading that will added in future tasks.

        Attachments

          Activity

          No builds found.
          jbosch Jim Bosch created issue -
          jbosch Jim Bosch made changes -
          Field Original Value New Value
          Status To Do [ 10001 ] In Progress [ 3 ]
          Hide
          jbosch Jim Bosch added a comment -

          Lauren, here's a fairly simple but wide-ranging review for you. It just removes a lot of temporary backwards compability code that isn't needed anymore. It touches five packages, and you can find the changesets in the GitHub PRs linked from the issue page.

          Note that this is just one part of a larger issue (DM-1766), and I plan to hold off on merging it (even though I think it should be safe to merge) until the other subtasks are done and reviewed as well (but I'll ask other people to review the other things).

          Show
          jbosch Jim Bosch added a comment - Lauren, here's a fairly simple but wide-ranging review for you. It just removes a lot of temporary backwards compability code that isn't needed anymore. It touches five packages, and you can find the changesets in the GitHub PRs linked from the issue page. Note that this is just one part of a larger issue ( DM-1766 ), and I plan to hold off on merging it (even though I think it should be safe to merge) until the other subtasks are done and reviewed as well (but I'll ask other people to review the other things).
          jbosch Jim Bosch made changes -
          Reviewers Lauren MacArthur [ lauren ]
          Status In Progress [ 3 ] In Review [ 10004 ]
          Hide
          jbosch Jim Bosch added a comment -

          Oops, just found another package that needed changes, meas_modelfit (changes there are extremely simple).

          Show
          jbosch Jim Bosch added a comment - Oops, just found another package that needed changes, meas_modelfit (changes there are extremely simple).
          Hide
          lauren Lauren MacArthur added a comment -

          This looks good to me, although it's difficult to assess if anything has been missed or is in err with no way to test (and very little familiarity with the old version!). I assume you will run Buildbot once all the necessary subtasks are in place before doing any merging, so I'm happy with the work here (but do see my minor comments in the PRs).

          Show
          lauren Lauren MacArthur added a comment - This looks good to me, although it's difficult to assess if anything has been missed or is in err with no way to test (and very little familiarity with the old version!). I assume you will run Buildbot once all the necessary subtasks are in place before doing any merging, so I'm happy with the work here (but do see my minor comments in the PRs).
          lauren Lauren MacArthur made changes -
          Status In Review [ 10004 ] Reviewed [ 10101 ]
          jbosch Jim Bosch made changes -
          Resolution Done [ 10000 ]
          Status Reviewed [ 10101 ] Done [ 10002 ]
          Hide
          jbosch Jim Bosch added a comment -

          I'm marking this as done because I've made all requested review changes, but it has not yet been merged to master - I'm making the changes on tickets/DM-1766, which I'll merge once all subtask issues have been reviewed. In the meantime, I'll keep the original subtask issue branches as they were to keep the all of the review diffs from changing constantly.

          Show
          jbosch Jim Bosch added a comment - I'm marking this as done because I've made all requested review changes, but it has not yet been merged to master - I'm making the changes on tickets/ DM-1766 , which I'll merge once all subtask issues have been reviewed. In the meantime, I'll keep the original subtask issue branches as they were to keep the all of the review diffs from changing constantly.

            People

            Assignee:
            jbosch Jim Bosch
            Reporter:
            jbosch Jim Bosch
            Reviewers:
            Lauren MacArthur
            Watchers:
            Jim Bosch, Lauren MacArthur
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Jenkins

                No builds found.