Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-1766 Remove in-memory support of old-version afw::table objects
  3. DM-2536

Backwards compatibility for reading slots and measurements from FITS

    Details

    • Type: Technical task
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: afw
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      Science Pipelines DM-S15-2, Science Pipelines DM-S15-3, Science Pipelines DM-S15-4
    • Team:
      Data Release Production

      Description

      Rename fields to match the new slot and measurement naming conventions.

        Attachments

          Activity

          Hide
          jbosch Jim Bosch added a comment -

          Perry, small review for you. This sits on top of several other tickets (DM-2533, DM-2534, DM-2535), and is the last step towards removing support for in-memory version 0 schemas while being able to read them in from disk as version 1 schemas. This just adds some logic to create aliases when reading version 0 schemas to allow them to be used by version 1 slots.

          All changes are in afw, and can be found in the GitHub PR linked from this JIRA page. Note that the diff is relative to tickets/DM-2535, which has been assigned to someone else to review.

          Show
          jbosch Jim Bosch added a comment - Perry, small review for you. This sits on top of several other tickets ( DM-2533 , DM-2534 , DM-2535 ), and is the last step towards removing support for in-memory version 0 schemas while being able to read them in from disk as version 1 schemas. This just adds some logic to create aliases when reading version 0 schemas to allow them to be used by version 1 slots. All changes are in afw, and can be found in the GitHub PR linked from this JIRA page. Note that the diff is relative to tickets/ DM-2535 , which has been assigned to someone else to review.
          Hide
          pgee Perry Gee added a comment -

          See github comments and my email. I'm not sure if I am supposed to do something in github as well – I have never attempt to merge changes from github pull requests, and am not sure is that needs to be done at some point by me.

          Show
          pgee Perry Gee added a comment - See github comments and my email. I'm not sure if I am supposed to do something in github as well – I have never attempt to merge changes from github pull requests, and am not sure is that needs to be done at some point by me.
          Hide
          jbosch Jim Bosch added a comment -

          No need to do anything in github with the merge button. In some cases, that'd be an easy way for to merge the ticket once it was ready, but that's not the reviewers responsibility right now in our workflow, and in this case the merge won't quite be that simple because of the other related issues that have to be merged together.

          Show
          jbosch Jim Bosch added a comment - No need to do anything in github with the merge button. In some cases, that'd be an easy way for to merge the ticket once it was ready, but that's not the reviewers responsibility right now in our workflow, and in this case the merge won't quite be that simple because of the other related issues that have to be merged together.
          Hide
          jbosch Jim Bosch added a comment -

          As with the other DM-1766 sub-issues, all review comments have been addressed on tickets/DM-1766, so I'll close this and leave tickets/DM-1766 to track teh final validation and merge.

          Show
          jbosch Jim Bosch added a comment - As with the other DM-1766 sub-issues, all review comments have been addressed on tickets/ DM-1766 , so I'll close this and leave tickets/ DM-1766 to track teh final validation and merge.

            People

            • Assignee:
              jbosch Jim Bosch
              Reporter:
              jbosch Jim Bosch
              Reviewers:
              Perry Gee
              Watchers:
              Jim Bosch, Perry Gee
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Summary Panel