Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-25424

Convert Defect to IsrCalib

    XMLWordPrintable

Details

    • Improvement
    • Status: Done
    • Resolution: Done
    • None
    • ip_isr, meas_algorithms
    • None
    • 15
    • Data Release Production

    Description

      Defects should be switched to use the IsrCalib base class, and should be migrated to ip_isr.

      Attachments

        Issue Links

          Activity

            This rework of Defects should be complete, so I'm putting it into review.  Due to the size and number of ticket branches, I'm splitting up the review as follows:

            tjenness: Can you please look over the meas_algorithms and ip_isr changes?

            plazas: Can you check the ci_cpp_gen2, ci_cpp_gen3, and cp_pipe changes?

            mfisherlevine: Can you check the remaining branches: ci_hsc_gen2, daf_butler, obs_base, obs_cfht, obs_decam, obs_lsst, obs_subaru, obs_test, and pipe_tasks?

            As always, if you want to look over other packages, please do so.  I didn't want to dump to much review on any one person.

            I'm also not in a great rush on this, as I'll be taking a few days off this week.

            czw Christopher Waters added a comment - This rework of Defects should be complete, so I'm putting it into review.  Due to the size and number of ticket branches, I'm splitting up the review as follows: tjenness : Can you please look over the meas_algorithms and ip_isr changes? plazas : Can you check the ci_cpp_gen2, ci_cpp_gen3, and cp_pipe changes? mfisherlevine : Can you check the remaining branches: ci_hsc_gen2, daf_butler, obs_base, obs_cfht, obs_decam, obs_lsst, obs_subaru, obs_test, and pipe_tasks? As always, if you want to look over other packages, please do so.  I didn't want to dump to much review on any one person. I'm also not in a great rush on this, as I'll be taking a few days off this week.

            All very small changes on my parts, so fine all round, just one query about what happened to the config defaults.

            mfisherlevine Merlin Fisher-Levine added a comment - All very small changes on my parts, so fine all round, just one query about what happened to the config defaults.
            tjenness Tim Jenness added a comment -

            I looked at the two branches and I have some minor comments on both. For ip_isr I would like the commit that copied the code from meas_algorithms to be distinct from the code that integrated it into ip_isr. This would let you blame me for that code.

            tjenness Tim Jenness added a comment - I looked at the two branches and I have some minor comments on both. For ip_isr I would like the commit that copied the code from meas_algorithms to be distinct from the code that integrated it into ip_isr. This would let you blame me for that code.

            I just had some small comments in cp_pipe, the main one related to the sign of nSigma (which now seems to be able to be negative and positive).

            plazas Andrés Alejandro Plazas Malagón added a comment - I just had some small comments in cp_pipe , the main one related to the sign of nSigma (which now seems to be able to be negative and positive).

            People

              czw Christopher Waters
              czw Christopher Waters
              Andrés Alejandro Plazas Malagón
              Andrés Alejandro Plazas Malagón, Christopher Waters, Merlin Fisher-Levine, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:

                Jenkins

                  No builds found.