Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: DM Subsystem Science, validate_drp, Validation, Verification
-
Labels:None
-
Epic Link:
-
Team:DM Science
-
Urgent?:No
Description
All metrics currently computed as part of this new framework are called as library functions from validate_drp. This was done to not duplicate work during development of the new framework. These should be ported to the new framework
Attachments
Issue Links
- blocks
-
DM-25508 Demonstrate scientific parity with validate_drp using new framework on the HSC RC2 dataset
- Done
Find the functions that need to be ported
$ grep -rnw 'python' -e 'lsst.validate.drp' | grep -v "Binary"
python/metric_pipeline_utils/phot_repeat.py:4:from lsst.validate.drp.repeatability import calcPhotRepeat
python/metric_pipeline_utils/separations.py:5:from lsst.validate.drp.util import (averageRaFromCat, averageDecFromCat,
python/metric_pipeline_tasks/MatchedCatalogMeasureTasks.py:10:from lsst.validate.drp.calcsrd.tex import (correlation_function_ellipticity_from_matches,
from lsst.validate.drp.repeatability import calcPhotRepeat
https://github.com/lsst/validate_drp/blob/master/python/lsst/validate/drp/repeatability.py
Also need calcPhotRepeatSample, computeWidths, getRandomDiffRmsInMmags, getRandomDiff
from lsst.validate.drp.util import (averageRaFromCat, averageDecFromCat, sphDist)
https://github.com/lsst/validate_drp/blob/master/python/lsst/validate/drp/util.py
Also need averageRaDecFromCat
from lsst.validate.drp.calcsrd.tex import (correlation_function_ellipticity_from_matches, select_bin_from_corr)
https://github.com/lsst/validate_drp/blob/master/python/lsst/validate/drp/calcsrd/tex.py
from ..util import (averageRaFromCat, averageDecFromCat, medianEllipticity1ResidualsFromCat, medianEllipticity2ResidualsFromCat)
Also need correlation_function_ellipticity, averageRaDec