Rewrite the scriptqueue ui subpackage to use salobj.Controller

XMLWordPrintable

Details

• Type: Improvement
• Status: Done
• Resolution: Done
• Fix Version/s: None
• Component/s: None
• Labels:
• Story Points:
2
• Sprint:
TSSW Sprint - Jun 22 - Jul 6, TSSW Sprint - Jul 6 - Jul 20
• Team:
Telescope and Site

Description

Rewrite the ts_scriptqueue ui subpackage to use salobj.Controller. This will greatly simplify use of asyncio (since that has a single loop that is always running).

Activity

Hide
Russell Owen added a comment - - edited

It turns out that this pushed salobj CscCommander's abilities a bit, so I added some features to that class as part of DM-25126. This means that this new code will require ts_salobj v5.17.0 (just released) or develop (salobj 6 release awaits ts_sal 4.2).

Here is a sequence that shows some of the changes and features

 # Start things up. CSC commanders do not launch CSCs, so do that manually. run_script_queue.py 1 & command_script_queue.py 1 -e # -e/--enable to enable the ScriptQueue   # You should see some "starting" messages, # followed by some events and help text. # You can issue the "help" command at any time to see the help text again.   # Show available scripts; unfortunately command names must be typed in full showAvailableScripts # I see the following: standard scripts: • set_summary_state.py • auxtel/standby_latiss.py • auxtel/slew_telescope_icrs.py ... external scripts: • auxtel/at_cam_take_image.py • auxtel/latiss_acquire_and_take_sequence.py • auxtel/latiss_acquire_target.py   # Run a script add std set_summary_state.py data=[ScriptQueue:1,enabled] # You should see some events as the script is launched (which takes some time) and runs   # When you are done with the commander: exit 

Pull request: https://github.com/lsst-ts/ts_scriptqueue/pull/48

Show
Russell Owen added a comment - - edited It turns out that this pushed salobj CscCommander 's abilities a bit, so I added some features to that class as part of DM-25126 . This means that this new code will require ts_salobj v5.17.0 (just released) or develop (salobj 6 release awaits ts_sal 4.2). Here is a sequence that shows some of the changes and features # Start things up. CSC commanders do not launch CSCs, so do that manually. run_script_queue.py 1 & command_script_queue.py 1 -e # -e/--enable to enable the ScriptQueue   # You should see some "starting" messages, # followed by some events and help text. # You can issue the "help" command at any time to see the help text again.   # Show available scripts; unfortunately command names must be typed in full showAvailableScripts # I see the following: standard scripts: • set_summary_state.py • auxtel/standby_latiss.py • auxtel/slew_telescope_icrs.py ... external scripts: • auxtel/at_cam_take_image.py • auxtel/latiss_acquire_and_take_sequence.py • auxtel/latiss_acquire_target.py   # Run a script add std set_summary_state.py data=[ScriptQueue:1,enabled] # You should see some events as the script is launched (which takes some time) and runs   # When you are done with the commander: exit Pull request: https://github.com/lsst-ts/ts_scriptqueue/pull/48
Hide
Tiago Ribeiro added a comment -

I reviewed the code in GitHub... I managed to test the new commander at NCSA. The code is much simpler than the previous ui. There's a bit of lost of features but I think it will be a feasible substitute.

Show
Tiago Ribeiro added a comment - I reviewed the code in GitHub... I managed to test the new commander at NCSA. The code is much simpler than the previous ui. There's a bit of lost of features but I think it will be a feasible substitute.
Hide
Russell Owen added a comment -

Released as v2.6.0

Show
Russell Owen added a comment - Released as v2.6.0

People

Assignee:
Russell Owen
Reporter:
Russell Owen
Reviewers:
Tiago Ribeiro
Watchers:
Russell Owen, Tiago Ribeiro