Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-25692

Write gen3 formatter for Exposure Filter

    XMLWordPrintable

    Details

    • Story Points:
      1
    • Team:
      Architecture
    • Urgent?:
      No

      Description

      In DM-25447 I discovered that a read-only Filter component for Exposure can't work because the information is derived from metadata that is stripped and a Filter can not be persisted since Filter.writeFits is broken.

      I propose that we write a very simple formatter that bypasses the FITS persistence system and simply writes a yaml file that includes the filter information. On read it will translate the filter name to a Filter object by looking it up in the filters singleton. This can then be set in the exposure using setFilter.

      This will turn filter into a normal component and should be quick to implement.

        Attachments

          Issue Links

            Activity

            Hide
            tjenness Tim Jenness added a comment -

            Krzysztof Findeisen would you mind reviewing this? The change is almost entirely addition of FilterFormatter that reads and writes a yaml file.

            Show
            tjenness Tim Jenness added a comment - Krzysztof Findeisen would you mind reviewing this? The change is almost entirely addition of FilterFormatter that reads and writes a yaml file.
            Hide
            krzys Krzysztof Findeisen added a comment -

            I have a number of recommendations on GitHub, but nothing too complicated. I'm disappointed this won't fix the existing issues on the Exposure side, but oh well.

            Show
            krzys Krzysztof Findeisen added a comment - I have a number of recommendations on GitHub, but nothing too complicated. I'm disappointed this won't fix the existing issues on the Exposure side, but oh well.

              People

              Assignee:
              tjenness Tim Jenness
              Reporter:
              tjenness Tim Jenness
              Reviewers:
              Krzysztof Findeisen
              Watchers:
              Jim Bosch, Krzysztof Findeisen, Tim Jenness
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  CI Builds

                  No builds found.