Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-25707

ts_salkafka seems to be ignoring ackcmd topic messages

    XMLWordPrintable

    Details

    • Story Points:
      0
    • Epic Link:
    • Sprint:
      TSSW Sprint - Jun 22 - Jul 6
    • Team:
      Telescope and Site
    • Urgent?:
      No

      Description

      The salkafka producers seem to not be sending out ackcmd Kafka messages when the SAL topic messages are received.

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. DM-25719 Cherry-pick the change to salobj 5 needed by salkakfa for DM-25707

          • Done

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            rowen Russell Owen added a comment - - edited

            The problem is that ts_salobj's ReadTopic adds an extra filter for "ackcmd" data, in order to weed out acknowledgements to commands issued by some other Remote. That's important for normal operation but not wanted for this situation.

            My fix was to add a new filter_ackcmd argument to salobj.ReadTopic. This defaults to True, for the old behavior, but ts_salkafka overrides it. I added a unit test whose doc string includes this ticket number.

            Pull request: https://github.com/lsst-ts/ts_salkafka/pull/14

            Note that this change requires ts_salobj 6 – which requires ts_sal 4.2. So using the fix awaits release of ts_sal 4.2. If that gets badly delayed I can release a new version of ts_salobj 5 that cherry-picks the necessary change.

            Show
            rowen Russell Owen added a comment - - edited The problem is that ts_salobj's ReadTopic adds an extra filter for "ackcmd" data, in order to weed out acknowledgements to commands issued by some other Remote. That's important for normal operation but not wanted for this situation. My fix was to add a new filter_ackcmd argument to salobj.ReadTopic . This defaults to True, for the old behavior, but ts_salkafka overrides it. I added a unit test whose doc string includes this ticket number. Pull request: https://github.com/lsst-ts/ts_salkafka/pull/14 Note that this change requires ts_salobj 6 – which requires ts_sal 4.2. So using the fix awaits release of ts_sal 4.2. If that gets badly delayed I can release a new version of ts_salobj 5 that cherry-picks the necessary change.
            Hide
            Permalink
            mareuter Michael Reuter added a comment -

            PR reviewed.

            Show
            mareuter Michael Reuter added a comment - PR reviewed.
            Hide
            Permalink
            rowen Russell Owen added a comment -

            Released as v1.3.0

            Show
            rowen Russell Owen added a comment - Released as v1.3.0

              People

              Assignee:
              rowen Russell Owen
              Reporter:
              mareuter Michael Reuter
              Reviewers:
              Michael Reuter
              Watchers:
              Michael Reuter, Russell Owen
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins

                  No builds found.