Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_middleware
-
Labels:
-
Story Points:0
-
Epic Link:
-
Sprint:TSSW Sprint - Jun 22 - Jul 6
-
Team:Telescope and Site
-
Urgent?:No
Description
The salkafka producers seem to not be sending out ackcmd Kafka messages when the SAL topic messages are received.
Attachments
Issue Links
- relates to
-
DM-25719 Cherry-pick the change to salobj 5 needed by salkakfa for DM-25707
- Done
The problem is that ts_salobj's ReadTopic adds an extra filter for "ackcmd" data, in order to weed out acknowledgements to commands issued by some other Remote. That's important for normal operation but not wanted for this situation.
My fix was to add a new filter_ackcmd argument to salobj.ReadTopic. This defaults to True, for the old behavior, but ts_salkafka overrides it. I added a unit test whose doc string includes this ticket number.
Pull request: https://github.com/lsst-ts/ts_salkafka/pull/14
Note that this change requires ts_salobj 6 – which requires ts_sal 4.2. So using the fix awaits release of ts_sal 4.2. If that gets badly delayed I can release a new version of ts_salobj 5 that cherry-picks the necessary change.