Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_main_telescope
-
Story Points:3
-
Sprint:TSSW Sprint - Jul 6 - Jul 20
-
Team:Telescope and Site
-
Urgent?:No
Description
Support the use of configuration file in rotator low-level controller. MOOG provided the middleware wrapper orginally that allows the user to update the configuration file by SAL. T&S team replaced it and used the Python CSC based on ts_salobj instead. This new CSC does not allow to do so. Therefore, this task will update the low-level controller code to let the user can configure the rotator by the configuration file.
Attachments
Issue Links
- relates to
-
- Done
Activity
Please help to review the PRs:
1. https://github.com/lsst-ts/ts_Dockerfiles/pull/88
2. https://github.com/lsst-ts/ts_rotator_controller/pull/8
The docker image is at:
https://hub.docker.com/repository/docker/lsstts/rotator_pxi
For the review of ts_rotator_controller, please ignore the first commit for the format change. For the update of commanding.c, the main change is to use `configRot_setBusRotCmdSig()` and remove the functions to read the txt files.
Thanks!
This looks fine to me. I had a few minor suggestions on the C string handling code.
Please consider restoring the older clang-format formatting on this ticket before merging, to avoid needless reformatting on develop and master. (At the cost of a bit more churn on this ticket branch). I hope you can convince your editor to use the same format (or just remove the linter that reformats and stick to the command line).
I tried to edit the settings.json to specify the path of clang-format in my host. However, the formats are still different between vscode and terminal. Therefore, I remove the setting of vscode to auto-save the clang-format change.
Installed the googletest and libyaml in the docker image of rotator_pxi. Uploaded the new image to docker hub (rotator_pxi ).