Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-25790

Support the Configuration File in Rotator Low-Level Controller Code

    XMLWordPrintable

    Details

      Description

      Support the use of configuration file in rotator low-level controller. MOOG provided the middleware wrapper orginally that allows the user to update the configuration file by SAL. T&S team replaced it and used the Python CSC based on ts_salobj instead. This new CSC does not allow to do so. Therefore, this task will update the low-level controller code to let the user can configure the rotator by the configuration file.

        Attachments

          Issue Links

            Activity

            No builds found.
            ttsai Te-Wei Tsai created issue -
            ttsai Te-Wei Tsai made changes -
            Field Original Value New Value
            Epic Link DM-23800 [ 431613 ]
            ttsai Te-Wei Tsai made changes -
            Description Support the use of configuration file in rotator low-level controller. MOOG provided the middleware wrapper orginally that allows the user to update the configuration file by SAL. T&S team replaced it and used the Python CSC based on ts_salobj instead. This new CSC does not allow to do so. Therefore, this task will update the low-level controller code to let the user can configure the rotator by the configuration file. Support the use of configuration file in rotator low-level controller. MOOG provided the middleware wrapper orginally that allows the user to update the configuration file by SAL. T&S team replaced it and used the Python CSC based on *ts_salobj* instead. This new CSC does not allow to do so. Therefore, this task will update the low-level controller code to let the user can configure the rotator by the configuration file.
            ttsai Te-Wei Tsai made changes -
            Status To Do [ 10001 ] In Progress [ 3 ]
            Hide
            ttsai Te-Wei Tsai added a comment - - edited

            Installed the googletest and libyaml in the docker image of rotator_pxi. Uploaded the new image to docker hub (rotator_pxi ).

            Show
            ttsai Te-Wei Tsai added a comment - - edited Installed the googletest and libyaml in the docker image of rotator_pxi. Uploaded the new image to docker hub ( rotator_pxi ).
            Hide
            ttsai Te-Wei Tsai added a comment -

            Please help to review the PRs:
            1. https://github.com/lsst-ts/ts_Dockerfiles/pull/88
            2. https://github.com/lsst-ts/ts_rotator_controller/pull/8

            The docker image is at:
            https://hub.docker.com/repository/docker/lsstts/rotator_pxi

            For the review of ts_rotator_controller, please ignore the first commit for the format change. For the update of commanding.c, the main change is to use `configRot_setBusRotCmdSig()` and remove the functions to read the txt files.

             

            Thanks!

            Show
            ttsai Te-Wei Tsai added a comment - Please help to review the PRs: 1. https://github.com/lsst-ts/ts_Dockerfiles/pull/88 2. https://github.com/lsst-ts/ts_rotator_controller/pull/8 The docker image is at: https://hub.docker.com/repository/docker/lsstts/rotator_pxi For the review of ts_rotator_controller, please ignore the first commit for the format change. For the update of commanding.c, the main change is to use `configRot_setBusRotCmdSig()` and remove the functions to read the txt files.   Thanks!
            ttsai Te-Wei Tsai made changes -
            Reviewers Russell Owen [ rowen ]
            Status In Progress [ 3 ] In Review [ 10004 ]
            Hide
            rowen Russell Owen added a comment -

            This looks fine to me. I had a few minor suggestions on the C string handling code.

            Please consider restoring the older clang-format formatting on this ticket before merging, to avoid needless reformatting on develop and master. (At the cost of a bit more churn on this ticket branch). I hope you can convince your editor to use the same format (or just remove the linter that reformats and stick to the command line).

            Show
            rowen Russell Owen added a comment - This looks fine to me. I had a few minor suggestions on the C string handling code. Please consider restoring the older clang-format formatting on this ticket before merging, to avoid needless reformatting on develop and master. (At the cost of a bit more churn on this ticket branch). I hope you can convince your editor to use the same format (or just remove the linter that reformats and stick to the command line).
            rowen Russell Owen made changes -
            Status In Review [ 10004 ] Reviewed [ 10101 ]
            Hide
            ttsai Te-Wei Tsai added a comment -

            I tried to edit the settings.json to specify the path of clang-format in my host. However, the formats are still different between vscode and terminal. Therefore, I remove the setting of vscode to auto-save the clang-format change.

            Show
            ttsai Te-Wei Tsai added a comment - I tried to edit the settings.json to specify the path of clang-format in my host. However, the formats are still different between vscode and terminal. Therefore, I remove the setting of vscode to auto-save the clang-format change.
            ttsai Te-Wei Tsai made changes -
            Resolution Done [ 10000 ]
            Status Reviewed [ 10101 ] Done [ 10002 ]
            ttsai Te-Wei Tsai made changes -
            Link This issue relates to DM-27764 [ DM-27764 ]

              People

              Assignee:
              ttsai Te-Wei Tsai
              Reporter:
              ttsai Te-Wei Tsai
              Reviewers:
              Russell Owen
              Watchers:
              Russell Owen, Te-Wei Tsai
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Start date:
                End date:

                  Jenkins

                  No builds found.