Details
-
Type:
Story
-
Status: Done
-
Resolution: Done
-
Fix Version/s: None
-
Component/s: ts_main_telescope
-
Story Points:3
-
Sprint:TSSW Sprint - Jul 20 - Aug 3
-
Team:Telescope and Site
-
Urgent?:No
Description
Fix the transition of tracking in deciding the tracking trajectory. In the previous update (DM-25243), I made two mistakes. One is that I do not generate a smooth velocity command in the tracking (I forgot the 4000 Hz internal calculation). The other one is that I do not stop the rotator's velocity smoothly if there is no new tracking command for some time. This ticket is to fix these two bugs.
Attachments
Issue Links
Activity
| Field | Original Value | New Value |
|---|---|---|
| Epic Link |
|
| Description | Fix the transition of tracking in deciding the tracking trajectory. In the previous update, I made two mistakes. One is that I do not generate a smooth velocity command in the tracking (I forgot the 4000 Hz internal calculation). The other one is that I do not stop the rotator's velocity smoothly if there is no new tracking command for some time. This ticket is to fix these two bugs. |
Fix the transition of tracking in deciding the tracking trajectory. In the previous update ( |
| Sprint | TSSW Sprint - Jul 6 - Jul 20 [ 1031 ] | TSSW Sprint - Jul 20 - Aug 3 [ 1034 ] |
| Status | To Do [ 10001 ] | In Progress [ 3 ] |
| Attachment | trackNeg.png [ 45053 ] | |
| Attachment | trackPos.png [ 45054 ] |
| Attachment | trackVel.png [ 45055 ] |
| Attachment | velDip.png [ 45056 ] |
Based on 'posErrorCalc_NewCmd' in 'Slew Mode Cmd Gen' subsystem, we can see the new received command (track) is always a command to reach instead of beginning.
| Attachment | badTransitionOfCmd.png [ 45066 ] |
Not sure why I have the bad transition in the negative direction (velocity=-0.01 deg/sec < 0) but not the positive one (velocity=0.01 deg/sec > 0):
| Attachment | digVelMagnify.png [ 45067 ] |
| Attachment | extrapolationMagnifySecondTarget.png [ 45070 ] | |
| Attachment | extrapolationMagnifyFirstTarget.png [ 45071 ] | |
| Attachment | extrapolationOverall.png [ 45072 ] |
Update the 'Track Mode Cmd Gen' subsystem to remove one of 'unit delay' to do the extrapolation:
The magnification of the first and second targets are:
After the discussion with Tiago, the pointing component always sends the future's target. Therefore, the rotator is doing the interpolation actually, although the method/ algorithm is bad. Based on this, the original code is correct, I should modify the code back.
Updated the code back as the following. The flags of tracking success/ fault seems to work still:
Discussed the interpolation algorithm with Tiago. The implemented code should update to use the algorithm suggested by Russell to fix the problem of jitter command. The ticket is DM-26156.
Discussed the discontinuous velocity with Tiago. I should issue a ticket to fix this. The added ticket is DM-26155.
| Attachment | updatedTracking.png [ 45074 ] |
Please help to review the PRs:
1. https://github.com/lsst-ts/ts_mt_hexRot_simulink/pull/11
2. https://github.com/lsst-ts/ts_rotator_controller/pull/10
You could just base on the comments in ticket to do the review. The details we had discussed today. Thanks!
| Reviewers | Tiago Ribeiro [ tribeiro ] | |
| Status | In Progress [ 3 ] | In Review [ 10004 ] |
Looks good...
| Status | In Review [ 10004 ] | Reviewed [ 10101 ] |
| Resolution | Done [ 10000 ] | |
| Status | Reviewed [ 10101 ] | Done [ 10002 ] |
Test condition: two targets. The first target is at 1.2 deg with velocity = 0.01 deg/sec. The second target is at 3 deg with velocity = -0.01 deg/sec.
The tracking velocity is continuous in the tracking process now:
There is a dip of velocity transition here (to 2nd target):
This velocity transitions from 0.01 deg/sec to -0.01 deg/sec happens in 0.005 seconds, which is 20 steps in 4000 Hz. We can see the acceleration > 0 for the new slew. Therefore, this transition does not make the physical sense at all.
The tracking target and position command have the wrong time order (the left figure is in the positive tracking and the right one is in the negative tracking):
Based on this order, I began to consider to use the interpolation instead.