Uploaded image for project: 'Data Management'
  1. Data Management
  2. DM-25807

refcat requireProperMotion=True config option bypassed for misconfigured catalog

    XMLWordPrintable

    Details

    • Type: Story
    • Status: Done
    • Resolution: Done
    • Fix Version/s: None
    • Component/s: meas_algorithms
    • Labels:
      None
    • Story Points:
      2
    • Sprint:
      AP F20-2 (July), AP F20-3 (August), AP F20-5 (October), AP S21-2 (January), AP S21-3 (February)
    • Team:
      Alert Production
    • Urgent?:
      No

      Description

      requireProperMotion=True does not result in a failure if the catalog is misconfigured (e.g. PS1 has pm_ra as a non-Angle). From the description of that config field and the logic in LoadReferenceObjectsTask.applyProperMotions(), it looks like loading the refcat should always fail if that field is True but proper motions cannot be applied for any reason. However, running with a PS1 refcat, you get the following message whether that field is True or not.:

      jointcal.astrometryRefObjLoader WARN: Catalog pm_ra field is not an Angle; not applying proper motion
      

      A section of LoadIndexedReferenceObjectsTask.loadSkyCircle() should be moved to the parent task applyProperMotions(), and similar logic in the gen3 loadRegion() should be moved out to a separate applyProperMotions(). I think this could be handled nicely with a custom exception. It looks like we don't have any tests of the behavior of this config field either.

      Note that correcting this will result in HSC failing to run with the jointcal defaults: they will need to set requireProperMotion=False, as PS1 does not have proper proper motions.

        Attachments

          Issue Links

            Activity

            Show
            Parejkoj John Parejko added a comment - - edited Jenkins: https://ci.lsst.codes/blue/organizations/jenkins/stack-os-matrix/detail/stack-os-matrix/33609/pipeline
            Hide
            Parejkoj John Parejko added a comment -

            Nate Lust: do you mind doing this medium-sized (~200 lines) review? In addition to the actual code in meas_algorithms, I had to fix a bug these changes uncovered in jointcal, and I hid some of the deprecation messages (see also DM-28577) in obs_cfht and obs_test because they were overwhelming test messages and we already know those particular uses are deprecated.

            Show
            Parejkoj John Parejko added a comment - Nate Lust : do you mind doing this medium-sized (~200 lines) review? In addition to the actual code in meas_algorithms, I had to fix a bug these changes uncovered in jointcal, and I hid some of the deprecation messages (see also DM-28577 ) in obs_cfht and obs_test because they were overwhelming test messages and we already know those particular uses are deprecated.
            Hide
            nlust Nate Lust added a comment -

            It all looks reasonable, but as per the warning in the ticket description, I would like to see a ticket branch that adds the required configs before this gets merged.

            Show
            nlust Nate Lust added a comment - It all looks reasonable, but as per the warning in the ticket description, I would like to see a ticket branch that adds the required configs before this gets merged.
            Hide
            Parejkoj John Parejko added a comment -

            That configuration problem for HSC+jointcal with this ticket was fixed on DM-25849.

            Show
            Parejkoj John Parejko added a comment - That configuration problem for HSC+jointcal with this ticket was fixed on DM-25849 .
            Hide
            nlust Nate Lust added a comment -

            Im sorry John, that was right in front of my face, your good to go. Have a good evening

            Show
            nlust Nate Lust added a comment - Im sorry John, that was right in front of my face, your good to go. Have a good evening

              People

              Assignee:
              Parejkoj John Parejko
              Reporter:
              Parejkoj John Parejko
              Reviewers:
              Nate Lust
              Watchers:
              John Parejko, Nate Lust, Paul Price
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Jenkins Builds

                  No builds found.